Bugzilla – Attachment 121994 Details for
Bug 28503
When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28503: (follow-up) Get rid of tests warnings
Bug-28503-follow-up-Get-rid-of-tests-warnings.patch (text/plain), 1.37 KB, created by
Tomás Cohen Arazi
on 2021-06-15 12:33:06 UTC
(
hide
)
Description:
Bug 28503: (follow-up) Get rid of tests warnings
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2021-06-15 12:33:06 UTC
Size:
1.37 KB
patch
obsolete
>From 9105fd3f0ba6ea1ab65f66579445400b84dfbd0d Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 14 Jun 2021 14:49:43 -0300 >Subject: [PATCH] Bug 28503: (follow-up) Get rid of tests warnings > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Reserves.t | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index cd55a13266..9f408629d9 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -1313,11 +1313,15 @@ subtest 'ModReserveAffect logging' => sub { > $hold = Koha::Holds->find($reserve_id); > is( $hold->timestamp, $previous_timestamp, 'Make sure the previous timestamp has been used' ); > >+ # Avoid warnings >+ my $reserve_mock = Test::MockModule->new('C4::Reserves'); >+ $reserve_mock->mock( '_koha_notify_reserve', undef ); >+ > # Mark it waiting > ModReserveAffect( $item->itemnumber, $patron->borrowernumber ); > >- $hold = Koha::Holds->find($reserve_id); >- is( $hold->found, 'W', 'Hold has been set waiting' ); >+ $hold->discard_changes; >+ ok( $hold->is_waiting, 'Hold has been set waiting' ); > isnt( $hold->timestamp, $previous_timestamp, 'The timestamp has been modified' ); > > my $log = Koha::ActionLogs->search({ module => 'HOLDS', action => 'MODIFY', object => $hold->reserve_id })->next; >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28503
:
121542
|
121543
|
121544
|
121614
|
121615
|
121616
|
121991
|
121992
|
121993
| 121994 |
122282