From 6c2127452e90b43e12a64c96b809630e7a4107c0 Mon Sep 17 00:00:00 2001 From: Andrew Isherwood Date: Mon, 26 Oct 2020 11:44:50 +0000 Subject: [PATCH] Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in Koha, creating the basket then modifying its header. We were logging these two steps in the wrong order. This commit fixes that. --- C4/Acquisition.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index ada432ac1f..352321ec86 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -203,8 +203,6 @@ sub NewBasket { $basketname ||= q{}; # default to empty strings $basketnote ||= q{}; $basketbooksellernote ||= q{}; - ModBasketHeader( $basket, $basketname, $basketnote, $basketbooksellernote, - $basketcontractnumber, $booksellerid, $deliveryplace, $billingplace, $is_standing, $create_items ); # Log the basket creation if (C4::Context->preference("AcquisitionLog")) { @@ -217,6 +215,9 @@ sub NewBasket { ); } + ModBasketHeader( $basket, $basketname, $basketnote, $basketbooksellernote, + $basketcontractnumber, $booksellerid, $deliveryplace, $billingplace, $is_standing, $create_items ); + return $basket; } -- 2.20.1