From 0d7d4f445a6320cfb8a407e0f84de2054ff339cf Mon Sep 17 00:00:00 2001 From: Andrew Isherwood Date: Mon, 26 Oct 2020 11:44:50 +0000 Subject: [PATCH] Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in Koha, creating the basket then modifying its header. We were logging these two steps in the wrong order. This commit fixes that. Signed-off-by: Nick Clemens --- C4/Acquisition.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 3d74f847a6..dc733b221a 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -199,8 +199,6 @@ sub NewBasket { $basketname ||= q{}; # default to empty strings $basketnote ||= q{}; $basketbooksellernote ||= q{}; - ModBasketHeader( $basket, $basketname, $basketnote, $basketbooksellernote, - $basketcontractnumber, $booksellerid, $deliveryplace, $billingplace, $is_standing, $create_items ); # Log the basket creation if (C4::Context->preference("AcquisitionLog")) { @@ -213,6 +211,9 @@ sub NewBasket { ); } + ModBasketHeader( $basket, $basketname, $basketnote, $basketbooksellernote, + $basketcontractnumber, $booksellerid, $deliveryplace, $billingplace, $is_standing, $create_items ); + return $basket; } -- 2.20.1