Bugzilla – Attachment 124709 Details for
Bug 28316
Fix ES crashes related to various punctuation characters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28316: add tests
Bug-28316-add-tests.patch (text/plain), 5.11 KB, created by
Martin Renvoize
on 2021-09-09 13:02:53 UTC
(
hide
)
Description:
Bug 28316: add tests
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2021-09-09 13:02:53 UTC
Size:
5.11 KB
patch
obsolete
>From 9c2fa8545c929c9acb237e30c7f2634986a82b1e Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Tue, 15 Jun 2021 10:40:27 +0300 >Subject: [PATCH] Bug 28316: add tests > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../SearchEngine/Elasticsearch/QueryBuilder.t | 58 ++++++++++++++++--- > 1 file changed, 50 insertions(+), 8 deletions(-) > >diff --git a/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >index b2ce6f4319..e9a1aa30ec 100755 >--- a/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >+++ b/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >@@ -187,7 +187,7 @@ subtest '_split_query() tests' => sub { > }; > > subtest '_clean_search_term() tests' => sub { >- plan tests => 12; >+ plan tests => 24; > > my $qb; > ok( >@@ -195,6 +195,8 @@ subtest '_clean_search_term() tests' => sub { > 'Creating a new QueryBuilder object' > ); > >+ t::lib::Mocks::mock_preference('QueryAutoTruncate', 0); >+ > my $res = $qb->_clean_search_term('an=123'); > is($res, 'koha-auth-number:123', 'equals sign replaced with colon'); > >@@ -207,26 +209,66 @@ subtest '_clean_search_term() tests' => sub { > $res = $qb->_clean_search_term('"unbalanced "quotes"'); > is($res, ' unbalanced quotes ', 'unbalanced quotes removed'); > >+ $res = $qb->_clean_search_term(':test query'); >+ is($res, 'test query', 'remove colon at the start'); >+ >+ $res = $qb->_clean_search_term('test query\:'); >+ is($res, 'test query', 'remove colon at the end'); >+ > $res = $qb->_clean_search_term('test : query'); >- is($res, 'test query', 'dangling colon removed'); >+ is($res, 'test query', 'dangling colon removed'); > > $res = $qb->_clean_search_term('test :: query'); >- is($res, 'test query', 'dangling double colon removed'); >+ is($res, 'test query', 'dangling double colon removed'); > > $res = $qb->_clean_search_term('test "another : query"'); > is($res, 'test "another : query"', 'quoted dangling colon not removed'); > >- $res = $qb->_clean_search_term('test {another part}'); >- is($res, 'test "another part"', 'curly brackets replaced correctly'); >+ $res = $qb->_clean_search_term('host-item:test:n'); >+ is($res, 'host-item:test\:n', 'screen colons properly'); >+ >+ $res = $qb->_clean_search_term('host-item:test:n:test:and more'); >+ is($res, 'host-item:test\:n\:test\:and more', 'screen multiple colons properly'); >+ >+ $res = $qb->_clean_search_term('host-item:te st:n'); >+ is($res, 'host-item:te st:n', 'leave colons as they are'); >+ >+ $res = $qb->_clean_search_term('test!'); >+ is($res, 'test', 'remove exclamation sign at the end of the line'); >+ >+ $res = $qb->_clean_search_term('test! and more'); >+ is($res, 'test and more', 'remove exclamation sign at with space after it'); >+ >+ $res = $qb->_clean_search_term('!test'); >+ is($res, '!test', 'exclamation sign left untouched'); >+ >+ $res = $qb->_clean_search_term('test [123 TO 345]'); >+ is($res, 'test [123 TO 345]', 'keep inculsive range untouched'); >+ >+ $res = $qb->_clean_search_term('test [test TO TEST} [and] {123 TO 456]'); >+ is($res, 'test [test TO TEST} \[and\] {123 TO 456]', 'keep exclusive range untouched'); >+ >+ $res = $qb->_clean_search_term('test [test TO TEST} ["[and] {123 TO 456]" "[balanced]"]'); >+ is($res, 'test [test TO TEST} \["[and] {123 TO 456]" "[balanced]"\]', 'keep exclusive range untouched'); >+ >+ $res = $qb->_clean_search_term('test[]test TO TEST] [ {123 to 345}}'); >+ is($res, 'test\[\]test TO TEST\] \[ \{123 to 345\}\}', 'screen all square and curly brackets'); >+ >+ t::lib::Mocks::mock_preference('QueryRegexEscapeOptions', 'escape'); >+ >+ $res = $qb->_clean_search_term('test inside regexps /this [a-z]/ and \/not [a-z]\/ and that [a-z] [a TO z]'); >+ is($res, 'test inside regexps \/this \[a-z\]\/ and \/not \[a-z\]\/ and that \[a-z\] [a TO z]', 'behaviour with QueryRegexEscapeOptions set to "escape"'); >+ >+ t::lib::Mocks::mock_preference('QueryRegexEscapeOptions', 'dont_escape'); > >- $res = $qb->_clean_search_term('test {another part'); >- is($res, 'test another part', 'unbalanced curly brackets replaced correctly'); >+ $res = $qb->_clean_search_term('test inside regexps /this [a-z]/ /this2 [a-z]/ [but] /this3 [a-z]/ and \/not [a-z]\/ and that [a-z] [a TO z]'); >+ is($res, 'test inside regexps /this [a-z]/ /this2 [a-z]/ \[but\] /this3 [a-z]/ and \/not \[a-z\]\/ and that \[a-z\] [a TO z]', 'behaviour with QueryRegexEscapeOptions set to "dont_escape"'); > > $res = $qb->_clean_search_term('ti:test AND kw:test'); > is($res, 'title:test AND test', 'ti converted to title, kw converted to empty string, dangling colon removed with space preserved'); > > $res = $qb->_clean_search_term('kw:test'); >- is($res, 'test', 'kw converted to empty string, dangling colon removed with space preserved'); >+ is($res, 'test', 'kw converted to empty string, dangling colon is removed'); > }; > > subtest '_join_queries' => sub { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28316
:
121435
|
121443
|
121561
|
121562
|
121751
|
121752
|
121753
|
121754
|
121755
|
121756
|
121837
|
121838
|
121839
|
121840
|
121841
|
121842
|
121975
|
121976
|
121977
|
121978
|
121979
|
121980
|
122103
|
122104
|
122105
|
122106
|
122107
|
122108
|
122201
|
122202
|
122203
|
122204
|
122205
|
122206
|
122801
|
122802
|
122803
|
122804
|
122805
|
122806
|
123601
|
123602
|
123603
|
123604
|
123605
|
123606
|
124372
|
124373
|
124374
|
124375
|
124376
|
124377
|
124378
|
124560
|
124561
|
124562
|
124563
|
124564
|
124565
|
124566
| 124709 |
124710
|
124711
|
124712
|
124713
|
124714
|
124715