Bugzilla – Attachment 126979 Details for
Bug 26326
Add Koha Objects for Import Records and Import Record Matches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26326: (follow-up) Address qa script failures
Bug-26326-follow-up-Address-qa-script-failures.patch (text/plain), 2.23 KB, created by
Nick Clemens (kidclamp)
on 2021-10-27 12:07:15 UTC
(
hide
)
Description:
Bug 26326: (follow-up) Address qa script failures
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-10-27 12:07:15 UTC
Size:
2.23 KB
patch
obsolete
>From 8f5200d23d69ce9ccea7054a10b71ed357d25e8f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 27 Oct 2021 12:02:02 +0000 >Subject: [PATCH] Bug 26326: (follow-up) Address qa script failures > >--- > Koha/Import/Record.pm | 4 ++-- > Koha/Import/Record/Matches.pm | 2 +- > t/db_dependent/Installer.t | 4 ---- > 3 files changed, 3 insertions(+), 7 deletions(-) > >diff --git a/Koha/Import/Record.pm b/Koha/Import/Record.pm >index 189d878dd8..efd017152e 100644 >--- a/Koha/Import/Record.pm >+++ b/Koha/Import/Record.pm >@@ -29,12 +29,12 @@ Koha::Import::Record - Koha Import Record Object class > > =head1 API > >-=head2 Class methods >- > =head2 Internal methods > > =head3 _type > >+Returns name of corresponding DBIC resultset >+ > =cut > > sub _type { >diff --git a/Koha/Import/Record/Matches.pm b/Koha/Import/Record/Matches.pm >index 6a89a188e0..ac15d24892 100644 >--- a/Koha/Import/Record/Matches.pm >+++ b/Koha/Import/Record/Matches.pm >@@ -39,7 +39,7 @@ Koha::Import::Record::Matches - Koha Import Record Matches Object set class > > Koha:Import::Record::Matches->search->unset_chosen(); > >-Unselect all candidates as matches for the current resultset >+Deselect all candidates as matches for the current resultset > > =cut > >diff --git a/t/db_dependent/Installer.t b/t/db_dependent/Installer.t >index ed8029c2e8..2e9c0e26c8 100755 >--- a/t/db_dependent/Installer.t >+++ b/t/db_dependent/Installer.t >@@ -70,14 +70,10 @@ ok( ! index_exists( 'borrowers', 'xxx'), 'Constraint xxx does not exist' ); > ok( foreign_key_exists( 'borrowers', 'borrowers_ibfk_1' ), 'FK borrowers_ibfk_1 exists' ); > ok( ! foreign_key_exists( 'borrowers', 'xxx' ), 'FK xxxx does not exist' ); > >-<<<<<<< HEAD > ok( unique_key_exists( 'items', 'itembarcodeidx' ), 'UNIQUE KEY itembarcodeidx exists' ); > ok( ! unique_key_exists( 'borrowers', 'xxx' ), 'UNIQUE KEY xxxx does not exist' ); > >- >-======= > ok( primary_key_exists( 'borrowers' ), 'Borrowers does have a primary key on some column'); >->>>>>>> Bug 26326: (follow-up) Add ability to check for existence of any primary key > ok( primary_key_exists( 'borrowers', 'borrowernumber'), 'Borrowers has primary key on borrowernumber'); > ok( ! primary_key_exists( 'borrowers', 'email'), 'Borrowers does not have a primary key on email'); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26326
:
109373
|
114817
|
118974
|
119017
|
120992
|
120993
|
121164
|
121165
|
121166
|
121199
|
121200
|
121201
|
124171
|
124172
|
124173
|
126979
|
127165
|
127166
|
127167
|
127168
|
127257
|
127258
|
127259