From c41e5dd010601cc264357c72600113feedfcb440 Mon Sep 17 00:00:00 2001 From: Florian Bontemps Date: Wed, 27 Oct 2021 12:50:42 +0000 Subject: [PATCH] Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. --- .../prog/en/modules/catalogue/detail.tt | 10 ++-------- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 12 +++--------- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 7c2b961d6c..07743dd2cd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -273,7 +273,7 @@ Holdings ([% itemloop.size() || 0 | html %]) [% END %] -[% IF ( MARCNOTES || notes ) %]
  • Descriptions ([% ( MARCNOTES.size || 1 ) | html %])
  • [% END %] +[% IF ( MARCNOTES ) %]
  • Descriptions ([% ( MARCNOTES.size || 1 ) | html %])
  • [% END %] [% IF ( subscriptionsnumber ) %]
  • Subscriptions
  • [% END %] [% IF Koha.Preference('AcquisitionDetails') %]
  • Acquisition details
  • [% END %] [% IF suggestions.count %]
  • Suggestion details
  • [% END %] @@ -654,12 +654,11 @@ Note that permanent location is a code, and location may be an authval. [% END %] -[% IF ( MARCNOTES || notes ) %] +[% IF ( MARCNOTES ) %]
    -[% IF ( MARCNOTES ) %] [% FOREACH MARCNOTE IN MARCNOTES %]

    [% IF MARCNOTE.marcnote.match('^https?://\S+$') %] @@ -668,11 +667,6 @@ Note that permanent location is a code, and location may be an authval. [% MARCNOTE.marcnote | html | html_line_break %] [% END %]

    - [% END %] -[% ELSE %] - [% IF ( notes ) %] -

    [% notes | html %]

    - [% END %] [% END %]
    diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 0d417a7771..0a52fab640 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -368,12 +368,10 @@ [% IF (SeparateHoldings) %]
  • Other holdings [% ' ( ' _ (otheritemloop.size || 0) _ ' )' | html %]
  • [% END %] - [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] + [% IF ( MARCNOTES || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] [% SET title_notes_count = 0 %] [% IF MARCNOTES %] [% SET title_notes_count = MARCNOTES.size %] - [% ELSIF notes %] - [% SET title_notes_count = 1 %] [% END %] [% IF SYNDETICS_SUMMARY %][% SET title_notes_count = title_notes_count + 1 %][% END %]
  • Title notes ( [% title_notes_count | html %] )
  • @@ -529,7 +527,7 @@ [% END # / SeparateHoldings %] - [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] + [% IF ( MARCNOTES || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
    @@ -550,15 +548,11 @@

    [% END %]
    - [% ELSE %] - [% IF ( notes ) %] -

    [% notes | html %]

    - [% END %] [% END %]
    - [% END # / IF MARCNOTES || notes %] + [% END # / IF MARCNOTES %] [% IF ( SyndeticsEnabled ) %] [% IF ( SyndeticsTOC && SYNDETICS_TOC ) %] -- 2.20.1