From 5f577920cd773a21fd840fb63784c94814c5b44b Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Tue, 2 Oct 2012 21:07:18 +0800 Subject: [PATCH] Bug 8861 - Undefined variables in batchMod.pl trigger error logs Content-Type: text/plain; charset="utf-8" Initialized $op, and changed lines like "$op => 1" and "$error => 1" into separate, conditional template param calls. Signed-off-by: Kyle M Hall --- tools/batchMod.pl | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/batchMod.pl b/tools/batchMod.pl index 3ba93a8..85e74c4 100755 --- a/tools/batchMod.pl +++ b/tools/batchMod.pl @@ -53,6 +53,7 @@ my $template_flag; if (!defined $op) { $template_name = "tools/batchMod.tmpl"; $template_flag = { tools => '*' }; + $op = q{}; } else { $template_name = ($del) ? "tools/batchMod-del.tmpl" : "tools/batchMod-edit.tmpl"; $template_flag = ($del) ? { tools => 'items_batchdel' } : { tools => 'items_batchmod' }; @@ -440,8 +441,8 @@ foreach my $tag (sort keys %{$tagslib}) { $template->param(%$items_display_hashref) if $items_display_hashref; $template->param( op => $nextop, - $op => 1, ); +$template->param( $op => 1 ) if $op; if ($op eq "action") { @@ -457,7 +458,7 @@ if ($op eq "action") { } foreach my $error (@errors) { - $template->param($error => 1); + $template->param($error => 1) if $error; } $template->param(src => $src); output_html_with_http_headers $input, $cookie, $template->output; -- 1.7.2.5