Bugzilla – Attachment 127221 Details for
Bug 27684
Serial add is confused by authorized values with a code of '0'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27684: Serial 0 is valid default value.
Bug-27684-Serial-0-is-valid-default-value.patch (text/plain), 1.15 KB, created by
Didier Gautheron
on 2021-11-02 15:41:24 UTC
(
hide
)
Description:
Bug 27684: Serial 0 is valid default value.
Filename:
MIME Type:
Creator:
Didier Gautheron
Created:
2021-11-02 15:41:24 UTC
Size:
1.15 KB
patch
obsolete
>From 0f4dc2a3340b522328754ef1db5baae72a613832 Mon Sep 17 00:00:00 2001 >From: Didier Gautheron <didier.gautheron@biblibre.com> >Date: Fri, 27 Aug 2021 12:18:24 +0200 >Subject: [PATCH] Bug 27684: Serial 0 is valid default value. > >To test: >1- Create a NOT_LOAN VA: code = 0 lib = available >2- Add a serial with one item >3- Check that in items modification 952$7 is on 'available' >4- Receive this serial. >5- Add item >6- check that not for loan is empty >6- Apply patch >7- redo 4,5 >8- check that not for loan is on 'available' >--- > C4/Items.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index ce285577bd..864b30d2ed 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1605,7 +1605,7 @@ sub PrepareItemrecordDisplay { > if ($itemrecord) { > ( $x, $defaultvalue ) = _find_value( $tag, $subfield->{subfield}, $itemrecord ); > } >- $defaultvalue = $subfield->{defaultvalue} unless $defaultvalue; >+ $defaultvalue //= $subfield->{defaultvalue}; > if ( !defined $defaultvalue ) { > $defaultvalue = q||; > } else { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27684
:
124169
| 127221