Bugzilla – Attachment 12723 Details for
Bug 8886
Uninitialized variable triggers error log entry in z3950_search.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8886 - Uninitialized variable triggers error log entry in z3950_search.pl
Bug-8886---Uninitialized-variable-triggers-error-l.patch (text/plain), 1.52 KB, created by
Mark Tompsett
on 2012-10-06 13:36:44 UTC
(
hide
)
Description:
Bug 8886 - Uninitialized variable triggers error log entry in z3950_search.pl
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2012-10-06 13:36:44 UTC
Size:
1.52 KB
patch
obsolete
>From 0ce29621fa87ee96f1b54ebf823d2de6de8da7b4 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Sat, 6 Oct 2012 21:09:19 +0800 >Subject: [PATCH] Bug 8886 - Uninitialized variable triggers error log entry > in z3950_search.pl >Content-Type: text/plain; charset="utf-8" > >Added "|| q{}" to the end of the declaration/initializations of >both $op and $frameworkcode. This prevents n+1 error log >entries, where n is the number of frameworks in biblio_framework. >--- > acqui/z3950_search.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/acqui/z3950_search.pl b/acqui/z3950_search.pl >index 9dc8b6e..6d8a26d 100755 >--- a/acqui/z3950_search.pl >+++ b/acqui/z3950_search.pl >@@ -50,7 +50,7 @@ my $dbh = C4::Context->dbh; > my $error = $input->param('error'); > my $biblionumber = $input->param('biblionumber'); > $biblionumber = 0 unless $biblionumber; >-my $frameworkcode = $input->param('frameworkcode'); >+my $frameworkcode = $input->param('frameworkcode') || q{}; > my $title = $input->param('title'); > my $author = $input->param('author'); > my $isbn = $input->param('isbn'); >@@ -60,7 +60,7 @@ my $lccall = $input->param('lccall'); > my $subject= $input->param('subject'); > my $dewey = $input->param('dewey'); > my $controlnumber = $input->param('controlnumber'); >-my $op = $input->param('op'); >+my $op = $input->param('op') || q{}; > my $booksellerid = $input->param('booksellerid'); > my $basketno = $input->param('basketno'); > my $noconnection; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8886
:
12723
|
13169
|
13170