Bugzilla – Attachment 12768 Details for
Bug 8834
Call to C4::Context::preference fails to pass $self in Circulation.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8834 - Call to C4::Context::preference fails to pass $self in Circulation.pm
Bug-8834---Call-to-C4Contextpreference-fails-to-pa.patch (text/plain), 1.20 KB, created by
Julian Maurice
on 2012-10-11 08:38:55 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8834 - Call to C4::Context::preference fails to pass $self in Circulation.pm
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2012-10-11 08:38:55 UTC
Size:
1.20 KB
patch
obsolete
>From 04e2ecd3e2be0807d4ef58c650986f952c86c3fe Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 27 Sep 2012 14:12:00 +0800 >Subject: [PATCH] Bug 8834 - Call to C4::Context::preference fails to pass > $self in Circulation.pm > >Changed: > my $circcontrol = C4::Context::preference('CircControl'); >To: > my $circcontrol = C4::Context->preference('CircControl'); >This will pass $self and 'CircControl' which will then prevent >a "Use of uninitialized value" error log entry. > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 7485de5..d2ed4a7 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1982,7 +1982,7 @@ sub _debar_user_on_return { > # $deltadays is a DateTime::Duration object > my $deltadays = $calendar->days_between( $dt_due, $dt_today ); > >- my $circcontrol = C4::Context::preference('CircControl'); >+ my $circcontrol = C4::Context->preference('CircControl'); > my $issuingrule = > GetIssuingRule( $borrower->{categorycode}, $item->{itype}, $branchcode ); > my $finedays = $issuingrule->{finedays}; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8834
:
12542
| 12768