Bugzilla – Attachment 12849 Details for
Bug 8888
question marks in series title facet links
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Question marks in series title facet links
SIGNED-OFF-Question-marks-in-series-title-facet-li.patch (text/plain), 1.45 KB, created by
Owen Leonard
on 2012-10-16 14:20:21 UTC
(
hide
)
Description:
[SIGNED-OFF] Question marks in series title facet links
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-10-16 14:20:21 UTC
Size:
1.45 KB
patch
obsolete
>From 1521f45c7831d197303b4ef31a301299971786a9 Mon Sep 17 00:00:00 2001 >From: Lyon3 Team <koha@univ-lyon3.fr> >Date: Mon, 8 Oct 2012 19:06:04 +0200 >Subject: [PATCH] [SIGNED-OFF] Question marks in series title facet links >Content-Type: text/plain; charset="utf-8" > >When series title include a question or exclamation mark, theese must be removed >to prevent search failure. > >http://bugs.koha-community.org/show_bug.cgi?id=8888 >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Before the patch: Series facet links with ! or ? return no results. >After the patch the same links return valid results. >--- > C4/Search.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 7c20780..3a63fcd 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -532,9 +532,9 @@ sub getRecords { > || ( $facets_info->{$link_value}->{'expanded'} ) ) > { > >- # Sanitize the link value ), ( will cause errors with CCL, >+ # Sanitize the link value : parenthesis, question and exclamation mark will cause errors with CCL > my $facet_link_value = $one_facet; >- $facet_link_value =~ s/(\(|\))/ /g; >+ $facet_link_value =~ s/[()!?¡¿Ø]/ /g; > > # fix the length that will display in the label, > my $facet_label_value = $one_facet; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8888
:
12731
|
12736
| 12849