Bugzilla – Attachment 130774 Details for
Bug 29625
Wrong var name in Koha::BiblioUtils get_all_biblios_iterator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29625: Fix var name in Koha::BiblioUtils get_all_biblios_iterator
Bug-29625-Fix-var-name-in-KohaBiblioUtils-getallbi.patch (text/plain), 1.45 KB, created by
Michal Denar
on 2022-02-17 21:47:12 UTC
(
hide
)
Description:
Bug 29625: Fix var name in Koha::BiblioUtils get_all_biblios_iterator
Filename:
MIME Type:
Creator:
Michal Denar
Created:
2022-02-17 21:47:12 UTC
Size:
1.45 KB
patch
obsolete
>From 66b54b0e5b9b82c8bbf8f2fb64164302c690d19d Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 2 Dec 2021 12:21:45 -1000 >Subject: [PATCH] Bug 29625: Fix var name in Koha::BiblioUtils > get_all_biblios_iterator > >In Koha::BiblioUtils, get_all_biblios_iterator method is a class level method like get_from_biblionumber. >So its first arg should be named $class instead of $self. >Even if this var in not used. > >Test plan : >1) Run Elasticsearch full rebuild with and without patch >2) Check all biblio records are in index > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > Koha/BiblioUtils.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/BiblioUtils.pm b/Koha/BiblioUtils.pm >index 1ece4a8317..8301210de4 100644 >--- a/Koha/BiblioUtils.pm >+++ b/Koha/BiblioUtils.pm >@@ -123,7 +123,7 @@ records instead of all. > =cut > > sub get_all_biblios_iterator { >- my ($self, %options) = @_; >+ my ($class, %options) = @_; > > my $search_terms = {}; > my ($slice_modulo, $slice_count); >@@ -153,7 +153,7 @@ sub get_all_biblios_iterator { > biblionumber => $row->biblionumber, > embed_items => 1 }); > my $next = eval { >- __PACKAGE__->new($marc, $row->biblionumber); >+ $class->new($marc, $row->biblionumber); > }; > if ($@) { > warn "Something went wrong reading record for biblio $row->biblionumber: $@\n"; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29625
:
128183
|
129629
|
129839
|
130774
|
130815
|
130816