Bugzilla – Attachment 13169 Details for
Bug 8886
Uninitialized variable triggers error log entry in z3950_search.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
z3950_search reducing uninitialized variables error log entries
0001-Bug-8886-Uninitialized-variables-trigger-error-log-e.patch (text/plain), 1.66 KB, created by
Mark Tompsett
on 2012-11-01 09:55:43 UTC
(
hide
)
Description:
z3950_search reducing uninitialized variables error log entries
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2012-11-01 09:55:43 UTC
Size:
1.66 KB
patch
obsolete
>From bfb06ed4cbd4548a541eaf9ab2dceb23cb8b234d Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 1 Nov 2012 17:19:32 +0800 >Subject: [PATCH] Bug 8886 - Uninitialized variables trigger error log entries > in z3950_search.pl >Content-Type: text/plain; charset="utf-8" > >Added "|| q{}" to the end of the declaration/initializations of >both $op and $frameworkcode. This prevents n+1 error log >entries, where n is the number of frameworks in biblio_framework. >--- > cataloguing/z3950_search.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/cataloguing/z3950_search.pl b/cataloguing/z3950_search.pl >index fd4eff9..74e196b 100755 >--- a/cataloguing/z3950_search.pl >+++ b/cataloguing/z3950_search.pl >@@ -35,7 +35,7 @@ my $input = new CGI; > my $dbh = C4::Context->dbh; > my $error = $input->param('error'); > my $biblionumber = $input->param('biblionumber') || 0; >-my $frameworkcode = $input->param('frameworkcode'); >+my $frameworkcode = $input->param('frameworkcode') || q{}; > my $title = $input->param('title'); > my $author = $input->param('author'); > my $isbn = $input->param('isbn'); >@@ -48,7 +48,7 @@ my $controlnumber = $input->param('controlnumber'); > my $stdid = $input->param('stdid'); > my $srchany = $input->param('srchany'); > my $random = $input->param('random') || rand(1000000000); # this var is not useful anymore just kept for rel2_2 compatibility >-my $op = $input->param('op'); >+my $op = $input->param('op') || q{}; > > my $page = $input->param('current_page') || 1; > $page = $input->param('goto_page') if $input->param('changepage_goto'); >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8886
:
12723
| 13169 |
13170