Bugzilla – Attachment 13208 Details for
Bug 8490
Error when adding label layout under plack
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8490: fix Plack error when creating label layout
Bug-8490-fix-Plack-error-when-creating-label-layou.patch (text/plain), 1.63 KB, created by
Jared Camins-Esakov
on 2012-11-02 12:17:39 UTC
(
hide
)
Description:
Bug 8490: fix Plack error when creating label layout
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-11-02 12:17:39 UTC
Size:
1.63 KB
patch
obsolete
>From 4cf840abc4387df8d0f627d8114a1b6d108e304b Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Fri, 2 Nov 2012 12:16:19 +0100 >Subject: [PATCH] Bug 8490: fix Plack error when creating label layout > >This patch fixes "Error message "Can't bless non-reference value at >/home/pi/koha/C4/Creators/Layout.pm line 111." when trying to add a >label layout while using plack." > >The $layout_id variable is set to 5001 on my setup. And 5001 is the Unix >port where I run Plack. WTH is this value stored in this variable ? >Because of >> my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || $ARGV[1] || ''; >in label-edit-layout.pl > >Removing $ARGV[1] solves the problem >Also removing $ARG[0] because I also don't think it's useful > >Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> >Signed off after confirming with Chris Nighswonger that these scripts >were not intended to be run from the command line. Works as promised. >--- > labels/label-edit-layout.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/labels/label-edit-layout.pl b/labels/label-edit-layout.pl >index 268912c..e814e3b 100755 >--- a/labels/label-edit-layout.pl >+++ b/labels/label-edit-layout.pl >@@ -41,8 +41,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > >-my $op = $cgi->param('op') || $ARGV[0] || ''; >-my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || $ARGV[1] || ''; >+my $op = $cgi->param('op') || ''; >+my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || ''; > my $layout_choice = $cgi->param('layout_choice') || ''; > our $layout = ''; > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8490
:
13197
| 13208