Bugzilla – Attachment 13209 Details for
Bug 8997
Dead code in C4/Language causing useless SQL queries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8997: Unnecessary call to getAllLanguages
Bug-8997-Unnecessary-call-to-getAllLanguages.patch (text/plain), 1.86 KB, created by
Jared Camins-Esakov
on 2012-11-02 12:26:08 UTC
(
hide
)
Description:
Bug 8997: Unnecessary call to getAllLanguages
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-11-02 12:26:08 UTC
Size:
1.86 KB
patch
obsolete
>From ddced313c5a862a271e4911f817347091242ebae Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Wed, 31 Oct 2012 18:22:14 +0100 >Subject: [PATCH] Bug 8997: Unnecessary call to getAllLanguages > >In C4/Language, getTranslatedLanguages calls getAllLanguage, passes it >to _build_languages_arrayref, that does nothing of it. Removing this >dead code will clean & reduce SQL overhead > >Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> >I tried switching between languages and enabling and disabling >languages, and could not see any change with the patch applied. >--- > C4/Languages.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/C4/Languages.pm b/C4/Languages.pm >index d0eed69..6ecd39b 100644 >--- a/C4/Languages.pm >+++ b/C4/Languages.pm >@@ -119,7 +119,6 @@ Returns a reference to an array of hashes: > sub getTranslatedLanguages { > my ($interface, $theme, $current_language, $which) = @_; > my $htdocs; >- my $all_languages = getAllLanguages(); > my @languages; > my @enabled_languages; > >@@ -161,7 +160,7 @@ sub getTranslatedLanguages { > $seen{$_}++ for @languages; > @languages = keys %seen; > } >- return _build_languages_arrayref($all_languages,\@languages,$current_language,\@enabled_languages); >+ return _build_languages_arrayref(\@languages,$current_language,\@enabled_languages); > } > > =head2 getAllLanguages >@@ -276,7 +275,7 @@ FIXME: this could be rewritten and simplified using map > =cut > > sub _build_languages_arrayref { >- my ($all_languages,$translated_languages,$current_language,$enabled_languages) = @_; >+ my ($translated_languages,$current_language,$enabled_languages) = @_; > my @translated_languages = @$translated_languages; > my @languages_loop; # the final reference to an array of hashrefs > my @enabled_languages = @$enabled_languages; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8997
:
13150
| 13209