From dfe8028656e744e0dcfc0380f43f6719e548a35a Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 6 May 2022 20:32:32 +0000 Subject: [PATCH] Bug 30714: Do no log update to holdingbranch When an item from another branch is checked in, the holdingbranch is updated, and this change is logged. We record the checkin in statistics, we do not need the cataloguing update logged To recreate: 1 - Enable cataloguing log 2 - Check in an item with a different holding branch 3 - Check the action logs 4 - There is a cataloguing log for the holdingbranch update 5 - Apply patch 6 - Repeate with another item 7 - No log added! Signed-off-by: Owen Leonard --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index d312961478..47f0541f73 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2207,7 +2207,7 @@ sub AddReturn { # the holdingbranch is updated if the document is returned to another location. # this is always done regardless of whether the item was on loan or not if ($item->holdingbranch ne $branch) { - $item->holdingbranch($branch)->store({ skip_record_index => 1, skip_holds_queue => 1 }); + $item->holdingbranch($branch)->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 }); } my $item_was_lost = $item->itemlost; -- 2.20.1