Bugzilla – Attachment 134894 Details for
Bug 30579
When placing item level hold, some options that are not used are not disabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30579: (follow-up) Expand range of controls which are disabled/enabled
Bug-30579-follow-up-Expand-range-of-controls-which.patch (text/plain), 4.62 KB, created by
Owen Leonard
on 2022-05-11 12:23:27 UTC
(
hide
)
Description:
Bug 30579: (follow-up) Expand range of controls which are disabled/enabled
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-05-11 12:23:27 UTC
Size:
4.62 KB
patch
obsolete
>From 79e0433a86eeb3c69df5c8bcd5e1ef5f1b5be95e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 10 May 2022 16:43:19 +0000 >Subject: [PATCH] Bug 30579: (follow-up) Expand range of controls which are > disabled/enabled > >This patch updates the process of switching between "hold next" and >"hold specific item" so that all relevant form fields are disabled. >--- > .../prog/en/modules/reserve/request.tt | 22 +++++++++---------- > 1 file changed, 11 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 30d47f645c..690676dc47 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -535,11 +535,11 @@ > <fieldset class="action"> > [% IF ( patron.borrowernumber ) %] > [% IF ( override_required ) %] >- <button type="submit" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place hold</button> >+ <button type="submit" id="hold_any_btn" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place hold</button> > [% ELSIF ( none_available ) %] >- <button type="submit" disabled="disabled" class="btn btn-default btn-disabled">Place hold</button> >+ <button type="submit" id="hold_any_btn" disabled="disabled" class="btn btn-default btn-disabled">Place hold</button> > [% ELSE %] >- <button type="submit" class="btn btn-default">Place hold</button> >+ <button type="submit" id="hold_any_btn" class="btn btn-default">Place hold</button> > [% END %] > [% END %] > </fieldset> >@@ -769,11 +769,11 @@ > <fieldset class="action"> > [% IF ( patron AND patron.borrowernumber ) %] > [% IF ( override_required ) %] >- <button type="submit" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place holds</button> >+ <button type="submit" id="hold_item_btn" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place holds</button> > [% ELSIF ( none_available ) %] >- <button class="btn btn-default" type="submit">Place holds</button> >+ <button class="btn btn-default" id="hold_item_btn" type="submit">Place holds</button> > [% ELSE %] >- <button type="submit" class="btn btn-default">Place hold</button> >+ <button type="submit" id="hold_item_btn" class="btn btn-default">Place hold</button> > [% END %] > [% END # /IF patron %] > </fieldset> <!-- /.action --> >@@ -938,7 +938,7 @@ > </table> <!-- /#requesttitles --> > > >- <fieldset class="action"> >+ <fieldset class="action">?? > [% IF ( patron AND patron.borrowernumber ) %] > [% IF ( override_required ) %] > <button type="submit" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place holds</button> >@@ -1382,11 +1382,11 @@ > > function ToggleHoldsToPlace() { > if ( $("#requestany").prop('checked') ) { >- $("#holds_to_place_count, #pickup, #itemtype").prop('disabled', false); >- $(".requestspecific").prop("disabled", true ); >+ $("#holds_to_place_count, #pickup, #itemtype, #hold_any_btn").prop('disabled', false); >+ $(".requestspecific, #hold_item_btn").prop("disabled", true ); > } else { >- $("#holds_to_place_count, #pickup, #itemtype").prop('disabled', true); >- $(".requestspecific").prop("disabled", false ); >+ $("#holds_to_place_count, #pickup, #itemtype, #hold_any_btn").prop('disabled', true); >+ $(".requestspecific, #hold_item_btn").prop("disabled", false ); > } > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30579
:
133549
|
133550
|
133574
|
133575
|
133689
|
133690
|
134270
|
134468
|
134469
|
134491
|
134492
|
134493
|
134893
|
134894
|
140951
|
140952
|
140953
|
140954
|
148835
|
148898
|
149271
|
150767
|
150786
|
151483
|
151493
|
151558
|
154881
|
154882
|
154883
|
154886
|
157787
|
157788
|
157789
|
157790
|
157791
|
157792
|
157937
|
157938
|
157939
|
157940
|
157941
|
157942
|
157943
|
163260
|
163261
|
163262
|
163263
|
163264
|
163265
|
163266
|
163267
|
166012
|
166013
|
166014
|
166015
|
166016
|
166017
|
166018
|
166019
|
166034
|
166035
|
166036
|
166037
|
166038
|
166039
|
166040
|
166041
|
166074
|
166075
|
166076
|
166077
|
166078
|
166079
|
166080
|
166081
|
166082
|
166264
|
166265
|
166266
|
166267
|
166268
|
166269
|
166270
|
166271
|
166272
|
166273
|
166274
|
166275