From 61b3cfe0d8009d0a6a8f6603937057b00bb426b6 Mon Sep 17 00:00:00 2001 From: jeremy breuillard Date: Wed, 18 May 2022 16:24:37 +0200 Subject: [PATCH] Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 --- .../value_builder/unimarc_field_182a.pl | 74 ------------ .../value_builder/unimarc_field_182c.pl | 74 ------------ ..._field_182-2.pl => unimarc_field_183-2.pl} | 4 +- .../value_builder/unimarc_field_183a.pl | 2 - .../value_builder/unimarc_field_182-2.tt | 58 ---------- .../value_builder/unimarc_field_182a.tt | 95 ---------------- .../value_builder/unimarc_field_182c.tt | 105 ------------------ .../value_builder/unimarc_field_183-2.tt | 2 +- 8 files changed, 3 insertions(+), 411 deletions(-) delete mode 100755 cataloguing/value_builder/unimarc_field_182a.pl delete mode 100755 cataloguing/value_builder/unimarc_field_182c.pl rename cataloguing/value_builder/{unimarc_field_182-2.pl => unimarc_field_183-2.pl} (96%) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt diff --git a/cataloguing/value_builder/unimarc_field_182a.pl b/cataloguing/value_builder/unimarc_field_182a.pl deleted file mode 100755 index e9eea3a384..0000000000 --- a/cataloguing/value_builder/unimarc_field_182a.pl +++ /dev/null @@ -1,74 +0,0 @@ -#!/usr/bin/perl - -# Copyright 2014 Rijksmuseum -# -# This file is part of Koha. -# -# Koha is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 3 of the License, or -# (at your option) any later version. -# -# Koha is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Koha; if not, see . - -use Modern::Perl; - -use Date::Calc; - -use Koha::Util::FrameworkPlugin qw(wrapper); -use C4::Auth qw( get_template_and_user ); -use CGI qw ( -utf8 ); -use C4::Context; -use C4::Output qw( output_html_with_http_headers ); - -my $builder= sub { - my $params = shift; - my $id = $params->{id}; - - return qq| -|; -}; - -my $launcher= sub { - my $params = shift; - my $cgi = $params->{cgi}; - my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ - template_name => "cataloguing/value_builder/unimarc_field_182a.tt", - query => $cgi, - type => "intranet", - flagsrequired => {editcatalogue => '*'}, - }); - my $results = scalar $cgi->param('result'); - - $template->param( - index => scalar $cgi->param('index'), - result => $results, - ); - - # Return the result of the position in the string, ex: abcde = 1=a, 2=b, 3=c... - my @x = split(//, $results); - my $i = 1; - for my $fresult (@x) { - $template->param("f$i" => $fresult); - ++$i; - } - output_html_with_http_headers $cgi, $cookie, $template->output; -}; - -# Return the hashref with the builder and launcher to FrameworkPlugin object. -# NOTE: If you do not need a popup but only use e.g. Focus, Blur etc. for a -# particular plugin, you only need to define and return the builder. -return { builder => $builder, launcher => $launcher }; diff --git a/cataloguing/value_builder/unimarc_field_182c.pl b/cataloguing/value_builder/unimarc_field_182c.pl deleted file mode 100755 index 0d39da435b..0000000000 --- a/cataloguing/value_builder/unimarc_field_182c.pl +++ /dev/null @@ -1,74 +0,0 @@ -#!/usr/bin/perl - -# Copyright 2014 Rijksmuseum -# -# This file is part of Koha. -# -# Koha is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 3 of the License, or -# (at your option) any later version. -# -# Koha is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Koha; if not, see . - -use Modern::Perl; - -use Date::Calc; - -use Koha::Util::FrameworkPlugin qw(wrapper); -use C4::Auth qw( get_template_and_user ); -use CGI qw ( -utf8 ); -use C4::Context; -use C4::Output qw( output_html_with_http_headers ); - -my $builder= sub { - my $params = shift; - my $id = $params->{id}; - - return qq| -|; -}; - -my $launcher= sub { - my $params = shift; - my $cgi = $params->{cgi}; - my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ - template_name => "cataloguing/value_builder/unimarc_field_182c.tt", - query => $cgi, - type => "intranet", - flagsrequired => {editcatalogue => '*'}, - }); - my $results = scalar $cgi->param('result'); - - $template->param( - index => scalar $cgi->param('index'), - result => $results, - ); - - # Return the result of the position in the string, ex: abcde = 1=a, 2=b, 3=c... - my @x = split(//, $results); - my $i = 1; - for my $fresult (@x) { - $template->param("f$i" => $fresult); - ++$i; - } - output_html_with_http_headers $cgi, $cookie, $template->output; -}; - -# Return the hashref with the builder and launcher to FrameworkPlugin object. -# NOTE: If you do not need a popup but only use e.g. Focus, Blur etc. for a -# particular plugin, you only need to define and return the builder. -return { builder => $builder, launcher => $launcher }; diff --git a/cataloguing/value_builder/unimarc_field_182-2.pl b/cataloguing/value_builder/unimarc_field_183-2.pl similarity index 96% rename from cataloguing/value_builder/unimarc_field_182-2.pl rename to cataloguing/value_builder/unimarc_field_183-2.pl index 02a93db86e..c717bb39e5 100755 --- a/cataloguing/value_builder/unimarc_field_182-2.pl +++ b/cataloguing/value_builder/unimarc_field_183-2.pl @@ -36,7 +36,7 @@ my $builder= sub { function Click$id(event) { var fieldvalue=\$('#'+event.data.id).val(); - window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_182-2.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes'); + window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_183-2.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes'); return false; /* prevents scrolling */ } |; @@ -46,7 +46,7 @@ my $launcher= sub { my $params = shift; my $cgi = $params->{cgi}; my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ - template_name => "cataloguing/value_builder/unimarc_field_182-2.tt", + template_name => "cataloguing/value_builder/unimarc_field_183-2.tt", query => $cgi, type => "intranet", flagsrequired => {editcatalogue => '*'}, diff --git a/cataloguing/value_builder/unimarc_field_183a.pl b/cataloguing/value_builder/unimarc_field_183a.pl index a66e4b7417..3d84bad848 100755 --- a/cataloguing/value_builder/unimarc_field_183a.pl +++ b/cataloguing/value_builder/unimarc_field_183a.pl @@ -26,8 +26,6 @@ use C4::Auth qw( get_template_and_user ); use CGI qw ( -utf8 ); use C4::Context; use C4::Output qw( output_html_with_http_headers ); -use Data::Dumper; - my $builder= sub { my $params = shift; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt deleted file mode 100644 index b759a2d21c..0000000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt +++ /dev/null @@ -1,58 +0,0 @@ -[% INCLUDE 'doc-head-open.inc' %] -Framework plugin example › Cataloguing › Koha -[% INCLUDE 'doc-head-close.inc' %] - - - - -

UNIMARC field 182-2 builder

- -
- - - - - -
- -
-

Cancel

-
- - - -[% INCLUDE 'popup-bottom.inc' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt deleted file mode 100644 index 03030b48b2..0000000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt +++ /dev/null @@ -1,95 +0,0 @@ -[% INCLUDE 'doc-head-open.inc' %] -Framework plugin example › Cataloguing › Koha -[% INCLUDE 'doc-head-close.inc' %] - - - - -

UNIMARC field 182a builder

- -
- - - - - - -
- -
-

Cancel

-
- - - -[% INCLUDE 'popup-bottom.inc' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt deleted file mode 100644 index e6eccb1922..0000000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt +++ /dev/null @@ -1,105 +0,0 @@ -[% INCLUDE 'doc-head-open.inc' %] -Framework plugin example › Cataloguing › Koha -[% INCLUDE 'doc-head-close.inc' %] - - - - -

UNIMARC field 182c builder

- -
- - - - - - -
- -
-

Cancel

-
- - - -[% INCLUDE 'popup-bottom.inc' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt index a9532f7677..112c106e95 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt @@ -3,7 +3,7 @@ [% INCLUDE 'doc-head-close.inc' %] - +

UNIMARC field 183-2 builder

-- 2.17.1