Bugzilla – Attachment 135694 Details for
Bug 30884
Incomplete replace of jQuery UI tabs in batch patron modification breaks the form sending
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30884: Fix jQuery selector to correctly detect active tab
Bug-30884-Fix-jQuery-selector-to-correctly-detect-.patch (text/plain), 1.80 KB, created by
Lucas Gass
on 2022-06-03 21:32:16 UTC
(
hide
)
Description:
Bug 30884: Fix jQuery selector to correctly detect active tab
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2022-06-03 21:32:16 UTC
Size:
1.80 KB
patch
obsolete
>From 8303385a3b3cdd502583fe589d25f4f8e8ba5c30 Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Fri, 3 Jun 2022 17:47:46 +0300 >Subject: [PATCH] Bug 30884: Fix jQuery selector to correctly detect active tab > >To reproduce: >1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. >2. It should give "No patron card numbers or borrowernumbers given." warning. >3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist > is sent with empty data. > >Apply the patch, and then: >1. Fill form Card number or Borrowernumber list and click Continue. >2. Get the result: table with patrons for editing or warning about not found number. >3. Using the inspector tool see that request has data from the active tab in the form. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index 18cf51e63a..4309ae87f7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -476,7 +476,7 @@ > }); > $("#patron_batchmod_form").on("submit", function(){ > /* Reset form fields on inactive tabs */ >- var tab = $(this).find('.ui-tabs-active:first a').attr('href'); >+ var tab = $(this).find('ul.nav-tabs li.active a').attr('href'); > if ( tab == '#usecardnumber' ) { > $("#borrowernumberuploadfile, #patron_list_id, #borrowernumberlist").val(""); > } else if ( tab == '#useborrowernumber' ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30884
:
135682
|
135694
|
135726