From bad53dae1a1efef807400c773090ee8edd5b76b0 Mon Sep 17 00:00:00 2001 From: Michal Urban Date: Wed, 15 Jun 2022 05:12:10 -0400 Subject: [PATCH] Continued from previous patch: Added test for correct number of items for each call of "get_items_that_fill" https://bugs.koha-community.org/show_bug.cgi?id=30447 --- t/db_dependent/Holds.t | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index 5b2140796a..41e652c733 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -1706,7 +1706,7 @@ subtest 'ModReserve can only update expirationdate for found holds' => sub { }; subtest 'Koha::Holds->get_items_that_can_fill returns items with datecancelled or (inclusive) datearrived' => sub { - plan tests => 5; + plan tests => 8; # biblio item with date arrived and date cancelled my $biblio1 = $builder->build_sample_biblio(); my $item1 = $builder->build_sample_item({ biblionumber => $biblio1->biblionumber }); @@ -1788,6 +1788,9 @@ subtest 'Koha::Holds->get_items_that_can_fill returns items with datecancelled o is($items_that_can_fill1->next->id, $item1->id, "Koha::Holds->get_items_that_can_fill returns item with defined datearrived and datecancelled"); is($items_that_can_fill1->count, 1, "Koha::Holds->get_items_that_can_fill returns 1 item with correct parameters"); is($items_that_can_fill2->next->id, $item2->id, "Koha::Holds->get_items_that_can_fill returns item with defined datearrived and undefined datecancelled"); + is($items_that_can_fill2->count, 1, "Koha::Holds->get_items_that_can_fill returns 1 item with correct parameters"); is($items_that_can_fill3->next->id, $item3->id, "Koha::Holds->get_items_that_can_fill returns item with undefined datearrived and defined datecancelled"); + is($items_that_can_fill3->count, 1, "Koha::Holds->get_items_that_can_fill returns 1 item with correct parameters"); is($items_that_can_fill4->next, undef, "Koha::Holds->get_items_that_can_fill doesn't return item with undefined datearrived and undefined datecancelled"); + is($items_that_can_fill4->count, 0, "Koha::Holds->get_items_that_can_fill returns 0 item"); } -- 2.25.1