From 08fdf5fc3b8239bcfe349fefadb37b0ff80d9c35 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 1 Jul 2022 14:46:26 +0000 Subject: [PATCH] Bug 31086: Prevent placing hold with no pickup location To test: 1 - Apply patch 2 - Repeat test on previous patch 3 - You should get a warning popup when attempting to save hold 4 - Reload page 5 - Inspect the HTML and manualy set #pickup value of selected option to "" 6 - Attempt to save hold 7 - You get the popup 8 - Place a hold normally (with location) and verify it works --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 275fe90e53..1cdec8f84a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1440,8 +1440,13 @@ else { msg = (_("- Please select an item to place a hold") + "\n"); } + } else { + if( $("#pickup").length < 1 || $("#pickup").val() == "" ){ + msg = _("- Please select a pickup location for this hold" + "\n"); + } } + if (msg == "") { $('#hold-request-form').preventDoubleFormSubmit(); return(true); -- 2.30.2