Bugzilla – Attachment 137652 Details for
Bug 31144
When modifying an order we should not load the vendor default discount
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31144: When modifying an order we should not load the vendor default discount
Bug-31144-When-modifying-an-order-we-should-not-lo.patch (text/plain), 1.97 KB, created by
ByWater Sandboxes
on 2022-07-12 18:53:21 UTC
(
hide
)
Description:
Bug 31144: When modifying an order we should not load the vendor default discount
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2022-07-12 18:53:21 UTC
Size:
1.97 KB
patch
obsolete
>From 2ab99383b67cd3e1b8c643fb9945f025c3d70e60 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 12 Jul 2022 18:39:06 +0000 >Subject: [PATCH] Bug 31144: When modifying an order we should not load the > vendor default discount > >After placing an order in a basket with a discount of "0" if you attempt to modify we will load the vendor default discount, this can lead to accidentally applying a discount when modifying other order parts > >To test: >0 - Have a vendor with a discount set >1 - Add an order to a basket >2 - While adding, set discount to 0 >3 - Add order - prices are calculated ocrrectly >4 - Modify order >5 - Note discount is populated with vendor discount >6 - Cancel >7 - Apply patch >8 - Modify order >9 - Discount remains at 0 >10 - Repeat with a vendor with no discount set >11 - Placing order not specifiying discount it remains blank >12 - Modifying order discount remains blank >13 - Modify order and set discount >14 - Confirm it is retained on modifcation > >Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index 468e93c0a7..13a47cb960 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -446,7 +446,7 @@ > [% END %] > <li> > <label for="discount">Discount: </label> >- [% IF ( orderdiscount ) %] >+ [% IF ( ordernumber ) %] > <input type="text" size="6" name="discount" id="discount" value="[% orderdiscount | html %]" onchange="updateCosts();" />% > [% ELSE %] > <input type="text" size="6" name="discount" id="discount" value="[% discount | html %]" onchange="updateCosts();" />% >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31144
:
137651
|
137652
|
137770