Bugzilla – Attachment 13798 Details for
Bug 6602
Reports dictionary doesn't properly recognize text columns
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 6602 - Reports dictionary doesn't properly recognize text columns
SIGNED-OFF-Bug-6602---Reports-dictionary-doesnt-pr.patch (text/plain), 1.57 KB, created by
Katrin Fischer
on 2012-11-30 07:14:01 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 6602 - Reports dictionary doesn't properly recognize text columns
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2012-11-30 07:14:01 UTC
Size:
1.57 KB
patch
obsolete
>From 38be8c1b5c877d26276a9651b8836a0ae964c292 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 20 Nov 2012 13:53:43 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 6602 - Reports dictionary doesn't properly > recognize text columns > >Reports dictionary won't let you set a comparison for MEDIUMTEXT columns. To >test, choose a MEDIUMTEXT column like borrowers.surname in Step 3 of adding >a new dictionary definition. Before the patch, in Step 4 you would not see >any kind of form field for entering a comparison. After patching Step 4 will >offer you a field labeled "Search string matches." > >Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >All tests and perlcritic pass. > >Test plan: >1) Reports > Reports dictionary > New definition >2) Step 1: Some name >3) Step 2: Patrons >4) Step 3: First name (mediumtext) >5) Step 4: Verify 'Search string matches' is offered. > >For both, surname (mediumtext) and first name (text) the program should offer you >"Search string matches" on step 4. >--- > reports/dictionary.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/dictionary.pl b/reports/dictionary.pl >index aae96c9..f27ce10 100755 >--- a/reports/dictionary.pl >+++ b/reports/dictionary.pl >@@ -108,7 +108,7 @@ elsif ( $phase eq 'New Term step 4' ) { > if ( $type eq 'DATE' || $type eq 'DATETIME' ) { > $tmp_hash{'date'} = 1; > } >- if ( $type eq 'TEXT' ) { >+ if ($type eq 'TEXT' || $type eq 'MEDIUMTEXT'){ > $tmp_hash{'text'} = 1; > } > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6602
:
4665
|
4996
|
4997
|
13569
|
13698
| 13798