Bugzilla – Attachment 138196 Details for
Bug 28864
The patron search results in the patron card creator doesn't seem to use PatronsPerPage syspref
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31120: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value
Bug-31120-Items-will-renew-for-zero--0--days-if-re.patch (text/plain), 1.75 KB, created by
ByWater Sandboxes
on 2022-07-28 08:42:23 UTC
(
hide
)
Description:
Bug 31120: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2022-07-28 08:42:23 UTC
Size:
1.75 KB
patch
obsolete
>From 72927d0a2fe2798fe277cf7e71e606f1bf3b81eb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 7 Jul 2022 15:14:59 -0400 >Subject: [PATCH] Bug 31120: Items will renew for zero ( 0 ) days if > renewalperiod is blank/empty value > >If the rule renewalperiod is the blank empty string instead of being null/undefined or non-existant, Koha will interpret the renewal period as being zero days instead of falling back to the issuelength rule. > >It makes sense to me that a literal 0 here should make it renew for zero days even though that is nonsensical. > >Test Plan: >1) Delete all your rules >2) Create an all/all/all rules with an empty string for renewal base > period >3) Note that renewing an item does nothing >4) Apply this patch >5) Restart all the things! >6) Renew again >7) Note the renewal uses the issuelength rule as intended > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> > >https://bugs.koha-community.org/show_bug.cgi?id=28864 >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index a18864dea7..5b57575f3b 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -3759,7 +3759,7 @@ sub CalcDateDue { > my $loanlength = > GetLoanLength( $borrower->{'categorycode'}, $itemtype, $branch ); > >- my $length_key = ( $isrenewal and defined $loanlength->{renewalperiod} ) >+ my $length_key = ( $isrenewal and defined $loanlength->{renewalperiod} and $loanlength->{renewalperiod} ne q{} ) > ? qq{renewalperiod} > : qq{issuelength}; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28864
:
123848
|
124787
|
134004
|
138194
|
138195
|
138196
|
138197
|
138379
|
138388