Bugzilla – Attachment 138840 Details for
Bug 31306
Add Koha::Items->search_ordered method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31306: Add tests for search_ordered
Bug-31306-Add-tests-for-searchordered.patch (text/plain), 6.73 KB, created by
Owen Leonard
on 2022-08-08 15:48:28 UTC
(
hide
)
Description:
Bug 31306: Add tests for search_ordered
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-08-08 15:48:28 UTC
Size:
6.73 KB
patch
obsolete
>From 0d043fcd53f86e4c818c76cd4ceab4e209190adc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 29 Jul 2022 13:06:20 +0200 >Subject: [PATCH] Bug 31306: Add tests for search_ordered > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > t/db_dependent/Koha/Items.t | 122 +++++++++++++++++++++++++++++++++++- > 1 file changed, 121 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t >index a9f0716433..77d4b7d2ff 100755 >--- a/t/db_dependent/Koha/Items.t >+++ b/t/db_dependent/Koha/Items.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 15; >+use Test::More tests => 16; > > use Test::MockModule; > use Test::Exception; >@@ -27,6 +27,7 @@ use Time::Fake; > > use C4::Circulation qw( AddIssue LostItem AddReturn ); > use C4::Context; >+use C4::Serials qw( NewIssue AddItem2Serial ); > use Koha::Item; > use Koha::Item::Transfer::Limits; > use Koha::Items; >@@ -1811,3 +1812,122 @@ subtest 'move_to_biblio() tests' => sub { > $schema->storage->txn_rollback; > > }; >+ >+subtest 'search_ordered' => sub { >+ >+ plan tests => 6; >+ >+ $schema->storage->txn_begin; >+ >+ my $library_a = $builder->build_object( >+ { class => 'Koha::Libraries', value => { branchname => 'TEST_A' } } ); >+ my $library_z = $builder->build_object( >+ { class => 'Koha::Libraries', value => { branchname => 'TEST_Z' } } ); >+ my $biblio = $builder->build_sample_biblio( { serial => 0 } ); >+ my $item1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber }); >+ my $item2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber }); >+ my $item3 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber }); >+ >+ { # Is not a serial >+ >+ # order_by homebranch.branchname >+ $item1->discard_changes->update( { homebranch => $library_z->branchcode } ); >+ $item2->discard_changes->update( { homebranch => $library_a->branchcode } ); >+ $item3->discard_changes->update( { homebranch => $library_z->branchcode } ); >+ is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ], >+ [ $item2->itemnumber, $item1->itemnumber, $item3->itemnumber ] ); >+ >+ # order_by me.enumchron >+ $biblio->items->update( { homebranch => $library_a->branchcode } ); >+ $item1->discard_changes->update( { enumchron => 'cc' } ); >+ $item2->discard_changes->update( { enumchron => 'bb' } ); >+ $item3->discard_changes->update( { enumchron => 'aa' } ); >+ is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ], >+ [ $item3->itemnumber, $item2->itemnumber, $item1->itemnumber ] ); >+ >+ # order_by LPAD( me.copynumber, 8, '0' ) >+ $biblio->items->update( { enumchron => undef } ); >+ $item1->discard_changes->update( { copynumber => '12345678' } ); >+ $item2->discard_changes->update( { copynumber => '34567890' } ); >+ $item3->discard_changes->update( { copynumber => '23456789' } ); >+ is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ], >+ [ $item1->itemnumber, $item3->itemnumber, $item2->itemnumber ] ); >+ >+ # order_by -desc => 'me.dateaccessioned' >+ $biblio->items->update( { copynumber => undef } ); >+ $item1->discard_changes->update( { dateaccessioned => '2022-08-19' } ); >+ $item2->discard_changes->update( { dateaccessioned => '2022-07-19' } ); >+ $item3->discard_changes->update( { dateaccessioned => '2022-09-19' } ); >+ is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ], >+ [ $item3->itemnumber, $item1->itemnumber, $item2->itemnumber ] ); >+ } >+ >+ { # Is a serial >+ >+ my $sub_freq = $builder->build( { source => 'SubscriptionFrequency' } ); >+ my $sub_np = >+ $builder->build( { source => 'SubscriptionNumberpattern' } ); >+ my $subscription = $builder->build_object( >+ { >+ class => 'Koha::Subscriptions', >+ value => { >+ biblionumber => $biblio->biblionumber, >+ periodicity => $sub_freq->{id}, >+ numberpattern => $sub_np->{id} >+ } >+ } >+ ); >+ $builder->build_object( >+ { >+ class => 'Koha::Subscription::Histories', >+ value => { >+ subscriptionid => $subscription->subscriptionid, >+ biblionumber => $biblio->biblionumber >+ } >+ } >+ ); >+ >+ $biblio->update( { serial => 1 } ); >+ my $serialid1 = >+ C4::Serials::NewIssue( "serialseq", $subscription->subscriptionid, >+ $biblio->biblionumber, 1, undef, undef, "publisheddatetext", >+ "notes", "routingnotes" ); >+ C4::Serials::AddItem2Serial( $serialid1, $item1->itemnumber ); >+ my $serialid2 = >+ C4::Serials::NewIssue( "serialseq", $subscription->subscriptionid, >+ $biblio->biblionumber, 1, undef, undef, "publisheddatetext", >+ "notes", "routingnotes" ); >+ C4::Serials::AddItem2Serial( $serialid2, $item2->itemnumber ); >+ my $serialid3 = >+ C4::Serials::NewIssue( "serialseq", $subscription->subscriptionid, >+ $biblio->biblionumber, 1, undef, undef, "publisheddatetext", >+ "notes", "routingnotes" ); >+ C4::Serials::AddItem2Serial( $serialid3, $item3->itemnumber ); >+ my $serial1 = Koha::Serials->find($serialid1); >+ my $serial2 = Koha::Serials->find($serialid2); >+ my $serial3 = Koha::Serials->find($serialid3); >+ >+ # order_by serial.publisheddate >+ $serial1->discard_changes->update( { publisheddate => '2022-09-19' } ); >+ $serial2->discard_changes->update( { publisheddate => '2022-07-19' } ); >+ $serial3->discard_changes->update( { publisheddate => '2022-08-19' } ); >+ is_deeply( >+ [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ], >+ [ $item2->itemnumber, $item3->itemnumber, $item1->itemnumber ] >+ ); >+ >+ # order_by me.enumchron >+ $serial1->discard_changes->update({ publisheddate => '2022-08-19' }); >+ $serial2->discard_changes->update({ publisheddate => '2022-08-19' }); >+ $serial3->discard_changes->update({ publisheddate => '2022-08-19' }); >+ $item1->discard_changes->update( { enumchron => 'cc' } ); >+ $item2->discard_changes->update( { enumchron => 'bb' } ); >+ $item3->discard_changes->update( { enumchron => 'aa' } ); >+ is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ], >+ [ $item3->itemnumber, $item2->itemnumber, $item1->itemnumber ] ); >+ >+ } >+ >+ $schema->storage->txn_rollback; >+ >+}; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31306
:
138806
|
138807
|
138808
|
138838
|
138839
|
138840
|
138905
|
138906
|
138907
|
138908