Bugzilla – Attachment 140320 Details for
Bug 31435
"Configure this table" appears for non-configurable tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31435: (QA follow-up) Don't pass explicitly default parameter values
Bug-31435-QA-follow-up-Dont-pass-explicitly-defaul.patch (text/plain), 1.83 KB, created by
Joonas Kylmälä
on 2022-09-07 15:53:39 UTC
(
hide
)
Description:
Bug 31435: (QA follow-up) Don't pass explicitly default parameter values
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2022-09-07 15:53:39 UTC
Size:
1.83 KB
patch
obsolete
>From 5fa7eaa78f9c2de9e5fbf197259c0bd9b28b6c0e Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Wed, 7 Sep 2022 18:49:59 +0300 >Subject: [PATCH] Bug 31435: (QA follow-up) Don't pass explicitly default > parameter values >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >For kohaTable these are the default values. > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >index 68fbe0f01a..ae78a07dad 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >@@ -383,7 +383,7 @@ > $(row).addClass('debug'); > } > }, >- }, null, 0); >+ }); > > $('#smtp_servers').on( "click", '.delete_server', function () { > var smtp_server_id = $(this).data('smtp-server-id'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >index b8ad34f6c5..01878722a3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >@@ -213,7 +213,7 @@ > "orderable": false > }, > ] >- }, null, 0); >+ }); > > $('#quotes').on( "click", '.delete_quote', function () { > var quote_id = decodeURIComponent($(this).data('quote-id')); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31435
:
139567
|
139570
|
140209
|
140210
|
140211
|
140260
|
140261
|
140265
|
140266
|
140318
|
140319
| 140320