Bugzilla – Attachment 141086 Details for
Bug 31649
Acquisition basket CSV export fails if biblio does not exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31649: Fix acquisition basket group CSV export if biblio does not exist
Bug-31649-Fix-acquisition-basket-group-CSV-export-.patch (text/plain), 3.62 KB, created by
David Nind
on 2022-09-29 12:27:57 UTC
(
hide
)
Description:
Bug 31649: Fix acquisition basket group CSV export if biblio does not exist
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-09-29 12:27:57 UTC
Size:
3.62 KB
patch
obsolete
>From d3130f46a66de98fdfb480e0b61a8332099b2fa5 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 28 Sep 2022 20:42:57 -1000 >Subject: [PATCH] Bug 31649: Fix acquisition basket group CSV export if biblio > does not exist > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Acquisition.pm | 45 ++++++++++++++++++++++++--------------------- > 1 file changed, 24 insertions(+), 21 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 960902c85c..1edd0520ef 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -394,30 +394,33 @@ sub GetBasketGroupAsCSV { > > foreach my $order (@orders) { > my $biblio = Koha::Biblios->find( $order->{biblionumber} ); >- my $biblioitem = $biblio->biblioitem; >+ my $biblioitem; >+ if ($biblio) { >+ $biblioitem = $biblio->biblioitem; >+ } > my $row = { >- clientnumber => $bookseller->accountnumber, >- basketname => $basket->{basketname}, >- ordernumber => $order->{ordernumber}, >- author => $biblio->author, >- title => $biblio->title, >- publishercode => $biblioitem->publishercode, >- publicationyear => $biblioitem->publicationyear, >- collectiontitle => $biblioitem->collectiontitle, >- isbn => $order->{isbn}, >- quantity => $order->{quantity}, >- rrp_tax_included => $order->{rrp_tax_included}, >- rrp_tax_excluded => $order->{rrp_tax_excluded}, >- discount => $bookseller->discount, >+ clientnumber => $bookseller->accountnumber, >+ basketname => $basket->{basketname}, >+ ordernumber => $order->{ordernumber}, >+ author => $biblio ? $biblio->author : q{}, >+ title => $biblio ? $biblio->title : q{}, >+ publishercode => $biblioitem ? $biblioitem->publishercode : q{}, >+ publicationyear => $biblioitem ? $biblioitem->publicationyear : q{}, >+ collectiontitle => $biblioitem ? $biblioitem->collectiontitle : q{}, >+ isbn => $order->{isbn}, >+ quantity => $order->{quantity}, >+ rrp_tax_included => $order->{rrp_tax_included}, >+ rrp_tax_excluded => $order->{rrp_tax_excluded}, >+ discount => $bookseller->discount, > ecost_tax_included => $order->{ecost_tax_included}, > ecost_tax_excluded => $order->{ecost_tax_excluded}, >- notes => $order->{order_vendornote}, >- entrydate => $order->{entrydate}, >- booksellername => $bookseller->name, >- bookselleraddress => $bookseller->address1, >- booksellerpostal => $bookseller->postal, >- contractnumber => $contract->{contractnumber}, >- contractname => $contract->{contractname}, >+ notes => $order->{order_vendornote}, >+ entrydate => $order->{entrydate}, >+ booksellername => $bookseller->name, >+ bookselleraddress => $bookseller->address1, >+ booksellerpostal => $bookseller->postal, >+ contractnumber => $contract->{contractnumber}, >+ contractname => $contract->{contractname}, > }; > my $temp = { > basketgroupdeliveryplace => $basketgroup->{deliveryplace}, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31649
:
141076
|
141077
|
141078
|
141084
|
141085
|
141086
|
141548
|
141549
|
141550