Bugzilla – Attachment 141090 Details for
Bug 31653
jQuery upgrade broke search button hover effect
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31653: Correct event names passed to jQuery on() function
Bug-31653-Correct-event-names-passed-to-jQuery-on-.patch (text/plain), 1.52 KB, created by
Lucas Gass
on 2022-09-29 14:07:05 UTC
(
hide
)
Description:
Bug 31653: Correct event names passed to jQuery on() function
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2022-09-29 14:07:05 UTC
Size:
1.52 KB
patch
obsolete
>From 37a5f8712231da43c0a766f469d9f6d424b92313 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 29 Sep 2022 12:20:30 +0000 >Subject: [PATCH] Bug 31653: Correct event names passed to jQuery on() function > >This patch replaces the obsolete .on("hover") with .on("mouseenter >mouseleave"). This will allow the code to work again following the last >jQuery upgrade. > >See Bug 20217 for discussion of the original implementation: >https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217#c14 > >To test, apply the patch and go to the staff interface. Hover your mouse >over the "Search" link in the header menu. The adjacent dropdown menu >button should have its hover state triggered. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >index ad62c347cf..22886e20d0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >@@ -110,7 +110,7 @@ $(document).ready(function() { > $("a[href$=\"/" + path + params + "\"]", navmenulist).addClass("current"); > } > >- $("#catalog-search-link a").on("hover", function(){ >+ $("#catalog-search-link a").on("mouseenter mouseleave", function(){ > $("#catalog-search-dropdown a").toggleClass("catalog-search-dropdown-hover"); > }); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31653
:
141083
|
141087
|
141088
|
141089
| 141090