Bugzilla – Attachment 141898 Details for
Bug 31785
Adding or editing library does not respect public flag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31785: (follow-up) Fix modify operation too
Bug-31785-follow-up-Fix-modify-operation-too.patch (text/plain), 1.05 KB, created by
Lucas Gass
on 2022-10-14 15:55:25 UTC
(
hide
)
Description:
Bug 31785: (follow-up) Fix modify operation too
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2022-10-14 15:55:25 UTC
Size:
1.05 KB
patch
obsolete
>From 1fd533df5595707b9dae2aaf62f14d4b3fcc3b75 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 14 Oct 2022 09:07:14 +0000 >Subject: [PATCH] Bug 31785: (follow-up) Fix modify operation too > >Test plan: >Enable SQL strict mode (koha-conf). >Modify branch, set Public to No. >Check. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > admin/branches.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/branches.pl b/admin/branches.pl >index 0b3a12f97a..112ca421d3 100755 >--- a/admin/branches.pl >+++ b/admin/branches.pl >@@ -87,7 +87,7 @@ if ( $op eq 'add_form' ) { > if ($is_a_modif) { > my $library = Koha::Libraries->find($branchcode); > for my $field (@fields) { >- if ( $field eq 'pickup_location' ) { >+ if( $field =~ /^(pickup_location|public)$/ ) { > # Don't fallback to undef/NULL, default is 1 in DB > $library->$field( scalar $input->param($field) ); > } else { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31785
:
141863
|
141864
|
141868
|
141897
| 141898