From fa0106e1e23368eca667651e5a64f717f18c5b30 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 18 Oct 2022 12:07:38 +0000 Subject: [PATCH] Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of
nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results Signed-off-by: David Nind Signed-off-by: Martin Renvoize --- koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 3 ++- .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index b9f4ec04ff..43aa6f43e8 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -948,7 +948,8 @@ fieldset { } .action { - margin-left: 1em; + margin: 0; + padding: .4em 0; } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt index 4e54485f08..877db11838 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt @@ -283,10 +283,10 @@ -
-
- - +
+ + +
[% END %] -- 2.20.1