Bugzilla – Attachment 14243 Details for
Bug 8299
overdue_notice.pl shows warning messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8299 - overdue_notice.pl shows error messages
Bug-8299---overduenoticepl-shows-error-messages.patch (text/plain), 1.67 KB, created by
Kyle M Hall
on 2012-12-21 15:57:26 UTC
(
hide
)
Description:
Bug 8299 - overdue_notice.pl shows error messages
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-12-21 15:57:26 UTC
Size:
1.67 KB
patch
obsolete
>From e3e37f2735d11dcbc1384df9e687a4ed8cc07b45 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 12 Dec 2012 02:43:29 +1300 >Subject: [PATCH] Bug 8299 - overdue_notice.pl shows error messages > >fixes 2 warnings... > > Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659. > Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > misc/cronjobs/overdue_notices.pl | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 737fa34..614ff60 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -679,7 +679,9 @@ sub parse_letter { > } > > my $currency_format; >- if ($params->{'letter'}->{'content'} =~ m/<fine>(.*)<\/fine>/o) { # process any fine tags... >+ if ( defined $params->{'letter'}->{'content'} >+ and $params->{'letter'}->{'content'} =~ m/<fine>(.*)<\/fine>/o ) >+ { # process any fine tags... > $currency_format = $1; > $params->{'letter'}->{'content'} =~ s/<fine>.*<\/fine>/<<items.fine>>/o; > } >@@ -689,7 +691,7 @@ sub parse_letter { > my $item_format = ''; > foreach my $item (@$i) { > my $fine = GetFine($item->{'itemnumber'}, $params->{'borrowernumber'}); >- if (!$item_format) { >+ if ( !$item_format and defined $params->{'letter'}->{'content'} ) { > $params->{'letter'}->{'content'} =~ m/(<item>.*<\/item>)/; > $item_format = $1; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8299
:
13996
|
13997
|
14243
|
14259