Bugzilla – Attachment 142498 Details for
Bug 17170
Add the ability to create 'saved searches' for use as filters when searching the catalog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17170: (follow-up) Hide existing filters section if no filters exist
Bug-17170-follow-up-Hide-existing-filters-section-.patch (text/plain), 2.64 KB, created by
Nick Clemens (kidclamp)
on 2022-10-24 12:45:58 UTC
(
hide
)
Description:
Bug 17170: (follow-up) Hide existing filters section if no filters exist
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-10-24 12:45:58 UTC
Size:
2.64 KB
patch
obsolete
>From d172c5e82b4f4b8bf39058d4db1b603fcd63f852 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 24 Oct 2022 12:45:33 +0000 >Subject: [PATCH] Bug 17170: (follow-up) Hide existing filters section if no > filters exist > >--- > .../prog/en/modules/catalogue/results.tt | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 7d6c99e60d..3e4c785003 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -737,11 +737,13 @@ > <label for="new_filter">Name:</label> > <input id="new_filter" name="new_filter" type="text"> > <a id="save_new_filter" class="btn btn-default btn-xs" href="#">Save</a> >- </br>OR</br> >- <h6>Replace existing search filter:</h6> >- <label for="existing_filters">Choose</label> >- <select id="existing_filters" name="existing_filters" class="search_filters_list"></select> >- <a id="replace_existing_filter" class="btn btn-default btn-xs" href="#">Replace</a> >+ <span class="existing_filters_section"> >+ </br>OR</br> >+ <h6>Replace existing search filter:</h6> >+ <label for="existing_filters">Choose</label> >+ <select id="existing_filters" name="existing_filters" class="search_filters_list"></select> >+ <a id="replace_existing_filter" class="btn btn-default btn-xs" href="#">Replace</a> >+ </span> > </div> > <div class="modal-footer"> > <a href="#" data-dismiss="modal" aria-hidden="true" class="cancel">Cancel</a> >@@ -840,6 +842,11 @@ > .then(resolve, reject); > }) > .then(function(filters) { >+ if( filters.length == 0 ){ >+ $(".existing_filters_section").hide(); >+ } else { >+ $(".existing_filters_section").show(); >+ } > filters.forEach(function(filter) { > const opt = $("<option/>"); > select.append(opt); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17170
:
133263
|
133264
|
133265
|
133266
|
133267
|
133268
|
133269
|
133270
|
133361
|
133376
|
137027
|
137028
|
137029
|
137030
|
137031
|
137032
|
137033
|
137034
|
137035
|
137036
|
137186
|
137187
|
137188
|
137189
|
137190
|
137191
|
137192
|
137193
|
137194
|
137195
|
137808
|
137809
|
137810
|
137811
|
137812
|
137813
|
137814
|
137815
|
137816
|
137817
|
138505
|
138506
|
138507
|
138508
|
138509
|
138510
|
138511
|
138512
|
138513
|
138514
|
139948
|
139949
|
139950
|
139951
|
139952
|
139953
|
139954
|
139955
|
139956
|
139957
|
141228
|
141229
|
141230
|
141231
|
141232
|
141233
|
141234
|
141235
|
141236
|
141237
|
141316
|
141317
|
141318
|
141319
|
141320
|
141321
|
141322
|
141323
|
141324
|
141325
|
141326
|
141327
|
141328
|
141348
|
141349
|
141350
|
141351
|
141352
|
141353
|
141354
|
141355
|
141356
|
141357
|
141358
|
141359
|
141360
|
141422
|
141423
|
141424
|
141425
|
141426
|
141427
|
141428
|
141429
|
141430
|
141431
|
141432
|
141433
|
141434
|
141435
|
141436
|
141437
|
141438
|
141461
|
141462
|
142365
|
142367
|
142368
|
142369
|
142370
|
142371
|
142372
|
142373
|
142374
|
142375
|
142376
|
142377
|
142378
|
142379
|
142380
|
142381
|
142382
|
142383
|
142384
|
142385
|
142494
| 142498