Bugzilla – Attachment 142547 Details for
Bug 31929
On vendor edit page options are not aligned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31929: Radio inputs need to be outside of respective labels
Bug-31929-Radio-inputs-need-to-be-outside-of-respe.patch (text/plain), 7.72 KB, created by
Lucas Gass
on 2022-10-24 18:27:52 UTC
(
hide
)
Description:
Bug 31929: Radio inputs need to be outside of respective labels
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2022-10-24 18:27:52 UTC
Size:
7.72 KB
patch
obsolete
>From 033d8b19ac4d371f7660cf03446ae2103308d855 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 24 Oct 2022 18:25:21 +0000 >Subject: [PATCH] Bug 31929: Radio inputs need to be outside of respective > labels > >1. Apply patch >2. Go to Acquisitions and edit or create a vendor. >3. Look at the radio buttons in the Ordering information section. >4. They should be properly aligned. >5. Make sure the form still works and you can save changes. >--- > .../prog/en/modules/acqui/supplier.tt | 80 ++++++++----------- > 1 file changed, 32 insertions(+), 48 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >index 934b18be67..dbd0ab6c50 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >@@ -201,19 +201,15 @@ > <legend>Ordering information</legend> > <ol><li><label for="activestatus">Vendor is:</label> > [% IF ( active ) %] >- <label class="radio" for="activestatus"> >- Active <input type="radio" id="activestatus" name="status" value="1" checked="checked" /> >- </label> >- <label class="radio" for="inactivestatus"> >- Inactive <input type="radio" id="inactivestatus" name="status" value="0" /> >- </label> >+ <label class="radio" for="activestatus">Active</label> >+ <input type="radio" id="activestatus" name="status" value="1" checked="checked" /> >+ <label class="radio" for="inactivestatus">Inactive</label> >+ <input type="radio" id="inactivestatus" name="status" value="0" /> > [% ELSE %] >- <label class="radio" for="activestatus"> >- Active <input type="radio" id="activestatus" name="status" value="1" /> >- </label> >- <label class="radio" for="inactivestatus"> >- Inactive <input type="radio" id="inactivestatus" name="status" value="0" checked="checked" /> >- </label> >+ <label class="radio" for="activestatus">Active</label> >+ <input type="radio" id="activestatus" name="status" value="1" /> >+ <label class="radio" for="inactivestatus">Inactive</label> >+ <input type="radio" id="inactivestatus" name="status" value="0" checked="checked" /> > [% END %]</li> > <li><label for="list_currency">List prices are: </label> > <select name="list_currency" id="list_currency"> >@@ -239,53 +235,41 @@ > </li> > <li><label for="gstyes">Tax number registered:</label> > [% IF ( gstreg ) %] >- <label class="radio" for="gstyes"> >- Yes <input type="radio" name="gst" id="gstyes" value="1" checked="checked" /> >- </label> >- <label class="radio" for="gstno"> >- No <input type="radio" name="gst" id="gstno" value="0" /> >- </label> >+ <label class="radio" for="gstyes">Yes</label> >+ <input type="radio" name="gst" id="gstyes" value="1" checked="checked" /> >+ <label class="radio" for="gstno">No</label> >+ <input type="radio" name="gst" id="gstno" value="0" /> > [% ELSE %] >- <label class="radio" for="gstyes"> >- Yes <input type="radio" name="gst" id="gstyes" value="1" /> >- </label> >- <label class="radio" for="gstno"> >- No <input type="radio" name="gst" id="gstno" value="0" checked="checked" /> >- </label> >+ <label class="radio" for="gstyes">Yes</label> >+ <input type="radio" name="gst" id="gstyes" value="1" /> >+ <label class="radio" for="gstno">No</label> >+ <input type="radio" name="gst" id="gstno" value="0" checked="checked" /> > [% END %]</li> > > <li><label for="list_gstyes">List prices:</label> > [% IF ( listincgst ) %] >- <label class="radio" for="list_gstyes"> >- Include tax <input type="radio" id="list_gstyes" name="list_gst" value="1" checked="checked" /> >- </label> >- <label class="radio" for="list_gstno"> >- Don't include tax <input type="radio" id="list_gstno" name="list_gst" value="0" /> >- </label> >+ <label class="radio" for="list_gstyes">Include tax</label> >+ <input type="radio" id="list_gstyes" name="list_gst" value="1" checked="checked" /> >+ <label class="radio" for="list_gstno">Don't include tax</label> >+ <input type="radio" id="list_gstno" name="list_gst" value="0" /> > [% ELSE %] >- <label class="radio" for="list_gstyes"> >- Include tax <input type="radio" id="list_gstyes" name="list_gst" value="1" /> >- </label> >- <label class="radio" for="list_gstno"> >- Don't include tax <input type="radio" id="list_gstno" name="list_gst" value="0" checked="checked" /> >- </label> >+ <label class="radio" for="list_gstyes">Include tax</label> >+ <input type="radio" id="list_gstyes" name="list_gst" value="1" /> >+ <label class="radio" for="list_gstno">Don't include tax</label> >+ <input type="radio" id="list_gstno" name="list_gst" value="0" checked="checked" /> > [% END %]</li> > > <li><label for="invoice_gstyes">Invoice prices:</label> > [% IF ( invoiceincgst ) %] >- <label class="radio" for="invoice_gstyes"> >- Include tax <input type="radio" id="invoice_gstyes" name="invoice_gst" value="1" checked="checked" /> >- </label> >- <label class="radio" for="invoice_gstno"> >- Don't include tax <input type="radio" id="invoice_gstno" name="invoice_gst" value="0" /> >- </label> >+ <label class="radio" for="invoice_gstyes">Include tax</label> >+ <input type="radio" id="invoice_gstyes" name="invoice_gst" value="1" checked="checked" /> >+ <label class="radio" for="invoice_gstno">Don't include tax</label> >+ <input type="radio" id="invoice_gstno" name="invoice_gst" value="0" /> > [% ELSE %] >- <label class="radio" for="invoice_gstyes"> >- Include tax <input type="radio" id="invoice_gstyes" name="invoice_gst" value="1" /> >- </label> >- <label class="radio" for="invoice_gstno"> >- Don't include tax <input type="radio" id="invoice_gstno" name="invoice_gst" value="0" checked="checked" /> >- </label> >+ <label class="radio" for="invoice_gstyes">Include tax</label> >+ <input type="radio" id="invoice_gstyes" name="invoice_gst" value="1" /> >+ <label class="radio" for="invoice_gstno">Don't include tax</label> >+ <input type="radio" id="invoice_gstno" name="invoice_gst" value="0" checked="checked" /> > [% END %]</li> > > [% IF gst_values %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31929
:
142464
|
142547
|
142549