Bugzilla – Attachment 143054 Details for
Bug 32006
Add page-section to local use system preference tab (admin)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32006: Add page-section for local use system preferences
Bug-32006-Add-page-section-for-local-use-system-pr.patch (text/plain), 1.90 KB, created by
David Nind
on 2022-11-03 01:39:33 UTC
(
hide
)
Description:
Bug 32006: Add page-section for local use system preferences
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-11-03 01:39:33 UTC
Size:
1.90 KB
patch
obsolete
>From fd036e94eb448ac0074d14207b709a8946395eea Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 2 Nov 2022 22:17:33 +0000 >Subject: [PATCH] Bug 32006: Add page-section for local use system preferences > >To test: >1. Go to the System preferences > Local use >2. Notice there is no page section and the table has much more space on the left than other system preference sections >3. Apply patch >4. Look again, the extra space on the left should be eliminated and the page-section should be added. >5. Use an HTML validator to spot errors. > >Note: I elimiated the inline style on the table that set the width to 80%. I don't see why that is needed but if it is we should be using CSS to do so. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/admin/systempreferences.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >index bfee4fc2b8..b0ded6f715 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >@@ -333,7 +333,8 @@ > <table> > [% ELSE %] > <h1>Local use preferences</h1> >- <table width="80%" id="sysprefst"> >+ <div class="page-section"> >+ <table id="sysprefst"> > <thead><tr> > <th>Preference</th> > <th>Explanation</th> >@@ -455,9 +456,10 @@ > > <td class="actions"><a class="btn btn-default btn-xs" href="[% loo.edit | url %]"><i class="fa fa-pencil"></i> Edit</a> <a class="btn btn-default btn-xs" href="[% loo.delete | url %]"><i class="fa fa-trash"></i> Delete</a></td> > </tr> >- [% END %]</tbody> >+ [% END %] >+ </tbody> > </table> >- >+ [% IF tab == 'local_use' %]</div>[% END %] > [% END %] > > </main> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32006
:
143045
|
143054
|
143070