Bugzilla – Attachment 143154 Details for
Bug 32104
Console error on additional_content.pl after saving
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32104: Prevent console error on additonal-contents.pl
Bug-32104-Prevent-console-error-on-additonal-conte.patch (text/plain), 1.39 KB, created by
Lucas Gass
on 2022-11-03 22:22:33 UTC
(
hide
)
Description:
Bug 32104: Prevent console error on additonal-contents.pl
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2022-11-03 22:22:33 UTC
Size:
1.39 KB
patch
obsolete
>From 72f9fa94a11b64f0edc92f83958654c998e0ce78 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 3 Nov 2022 22:20:57 +0000 >Subject: [PATCH] Bug 32104: Prevent console error on additonal-contents.pl > >To test: >1. Make a new HTML customization, news item, or page with the text editor ( CodeMirror ). >2. Save the content ( not Save and continue ) >3. Notice the console error: >4. Apply patch >5. Try 1 & 2 again. >6. No error. >--- > .../prog/en/modules/tools/additional-contents.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >index 9e2d34a26b8..0375c783de7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >@@ -680,7 +680,9 @@ > /* Activate first tab and initialize its CodeMirror instance */ > let firstTab = $("#tabs a:first"); > firstTab.tab("show"); >- initCodeMirror( firstTab[0].hash ); >+ if ( firstTab[0] ) { >+ initCodeMirror( firstTab[0].hash ); >+ } > } > > $("#tabs a[data-toggle='tab']").on("shown.bs.tab", function (e) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32104
:
143154
|
143164
|
144021