Bugzilla – Attachment 143459 Details for
Bug 32030
Electronic resource management (ERM)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32030: Fix perlcritic errors
Bug-32030-Fix-perlcritic-errors.patch (text/plain), 1.93 KB, created by
Jonathan Druart
on 2022-11-09 08:01:34 UTC
(
hide
)
Description:
Bug 32030: Fix perlcritic errors
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-11-09 08:01:34 UTC
Size:
1.93 KB
patch
obsolete
>From 5c60a1772c5dc55f7d20282cbcbbfc69ae1db247 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 9 Nov 2022 09:00:47 +0100 >Subject: [PATCH] Bug 32030: Fix perlcritic errors > >--- > Koha/ERM/Providers/EBSCO.pm | 1 - > Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm | 1 - > Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm | 1 - > 3 files changed, 3 deletions(-) > >diff --git a/Koha/ERM/Providers/EBSCO.pm b/Koha/ERM/Providers/EBSCO.pm >index 3c3ccf86db1..38217b5fa29 100644 >--- a/Koha/ERM/Providers/EBSCO.pm >+++ b/Koha/ERM/Providers/EBSCO.pm >@@ -223,7 +223,6 @@ sub build_query { > > return $url unless $params && %$params; > while ( my ( $attr, $value ) = each %$params ) { >- my $their_attr; > if ( $attr eq 'name' ) { > $url .= '&search=' . $value; > } >diff --git a/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm b/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm >index 6afe15d0f21..5f945872807 100644 >--- a/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm >+++ b/Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm >@@ -76,7 +76,6 @@ sub list { > > my ( $per_page, $page ) = $ebsco->build_query_pagination($args); > >- my ( $search, $content_type, $selection_type ); > my $additional_params = $ebsco->build_additional_params( $c->req->params->to_hash ); > my $searchfield = 'titlename'; > >diff --git a/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm b/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm >index 73132f89f60..cc2f4142b2d 100644 >--- a/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm >+++ b/Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm >@@ -46,7 +46,6 @@ sub list { > > my ( $per_page, $page ) = $ebsco->build_query_pagination($args); > >- my ( $search, $content_type, $selection_type ); > my $additional_params = $ebsco->build_additional_params( $c->req->params->to_hash ); > > unless ( defined $additional_params->{publication_title} ) { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32030
:
143458
| 143459 |
143460
|
143461
|
143502