Bugzilla – Attachment 143606 Details for
Bug 31928
Add page-section to callnumber browser value builder (cat)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31928: Add page-section to callnumber browser value builder (cat)
Bug-31928-Add-page-section-to-callnumber-browser-v.patch (text/plain), 6.56 KB, created by
Katrin Fischer
on 2022-11-09 23:46:03 UTC
(
hide
)
Description:
Bug 31928: Add page-section to callnumber browser value builder (cat)
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-11-09 23:46:03 UTC
Size:
6.56 KB
patch
obsolete
>From 9da90efec74ebc7e4cbc6e24e4c2e296a6e7f521 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 9 Nov 2022 18:19:51 +0000 >Subject: [PATCH] Bug 31928: Add page-section to callnumber browser value > builder (cat) > >This patch adds a page-section div around the search results shown by >the call number browser plugin in Cataloging. > >The patch also restructures the search form so that the layout is >correct. > >To test you must have an item subfield linked to the call number browser >plugin: > >- Go to MARC frameworks -> Default MARC framework -> MARC structure. >- Locate the 952 tag and click Actions -> Edit subfields. >- Open the "o" tab and in the last section, "Other options," choose > "cn_browser.pl" for the plugin field. > >Open an item record for editing: > >- Go to Cataloging and search for a bibliographic record. >- Click Actions -> Add/Edit items for one of the results. >- In the item edit form, the "o - Full call number" field should have a > "..." link at the end. >- Clicking it should trigger a popup window. >- The search form at the top should be laid out correctly. >- Perform a search which will return results. >- The table of results should be contained within a white box. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../cataloguing/value_builder/cn_browser.tt | 98 ++++++++++--------- > 1 file changed, 53 insertions(+), 45 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt >index dc239e2624..12364d9e6b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt >@@ -15,53 +15,61 @@ > > <h1>Call number browser</h1> > >-<div> > <form id="cn_browser" method="get" action="/cgi-bin/koha/cataloguing/plugin_launcher.pl"> >- <label for="searchcn">Search call number:</label> >- <input type="text" id="cn_browser_input" name="q" value="[% q | html %]" /> >- <input id="cn_browser_submit" type="submit" value="Search" /> >- <input name="plugin_name" type="hidden" value="cn_browser.pl"/> >- <input name="popup" type="hidden" value="[% popup | html %]"/> >- </br> >- <label for="cn_source">Call number classification scheme:</label> >- <select name="cn_source" form="cn_browser"> >- [% FOREACH class_source IN class_sources %] >- [% IF class_source.cn_source == cn_source %] >- <option value="[% class_source.cn_source | html %]" selected="selected">[% class_source.description | html %]</option> >- [% ELSE %] >- <option value="[% class_source.cn_source | html %]">[% class_source.description | html %]</option> >- [% END %] >- [% END %] >- </select> >+ <fieldset class="brief"> >+ <ol> >+ <li> >+ <label for="searchcn">Search call number:</label> >+ <input type="text" id="cn_browser_input" name="q" value="[% q | html %]" /> >+ <input name="plugin_name" type="hidden" value="cn_browser.pl"/> >+ <input name="popup" type="hidden" value="[% popup | html %]"/> >+ </li> >+ <li> >+ <label for="cn_source">Call number classification scheme:</label> >+ <select name="cn_source" form="cn_browser"> >+ [% FOREACH class_source IN class_sources %] >+ [% IF class_source.cn_source == cn_source %] >+ <option value="[% class_source.cn_source | html %]" selected="selected">[% class_source.description | html %]</option> >+ [% ELSE %] >+ <option value="[% class_source.cn_source | html %]">[% class_source.description | html %]</option> >+ [% END %] >+ [% END %] >+ </select> >+ </li> >+ </ol> >+ <fieldset class="action"> >+ <input id="cn_browser_submit" type="submit" value="Search" /> >+ </fieldset> >+ </fieldset> > </form> >-</div> >-<br /> > >-<table id="cn_browser_table"> >- <thead><tr> >- <th>Call number</th> >- <th>Title</th> >- <th>Library</th> >- <th>Collection</th> >- </tr></thead> >- <tbody> >-[% FOREACH cn_loo IN cn_loop %] >- <tr> >- <td style="background:[% cn_loo.background | html %];">[% cn_loo.itemcallnumber | html %]</td> >- <td style="background:[% cn_loo.background | html %];"> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% cn_loo.biblionumber | uri %]"> >- [% cn_loo.title | html %] [% cn_loo.subtitle | html %] [% cn_loo.subtitle2 | html %] >- [% IF ( cn_loo.author ) %] >- <span>by</span> [% cn_loo.author | html %] >- [% END %] >- [% IF ( cn_loo.barcode ) %] ([% cn_loo.barcode | html %])[% END %] >- </a> >- </td> >- <td style="background:[% cn_loo.background | html %];">[% cn_loo.branchname | html %]</td> >- <td style="background:[% cn_loo.background | html %];">[% AuthorisedValues.GetByCode( 'CCODE', cn_loo.ccode ) | html %]</td> >- </tr> >-[% END %] >- </tbody> >-</table> >+<div class="page-section"> >+ <table id="cn_browser_table"> >+ <thead><tr> >+ <th>Call number</th> >+ <th>Title</th> >+ <th>Library</th> >+ <th>Collection</th> >+ </tr></thead> >+ <tbody> >+ [% FOREACH cn_loo IN cn_loop %] >+ <tr> >+ <td style="background:[% cn_loo.background | html %];">[% cn_loo.itemcallnumber | html %]</td> >+ <td style="background:[% cn_loo.background | html %];"> >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% cn_loo.biblionumber | uri %]"> >+ [% cn_loo.title | html %] [% cn_loo.subtitle | html %] [% cn_loo.subtitle2 | html %] >+ [% IF ( cn_loo.author ) %] >+ <span>by</span> [% cn_loo.author | html %] >+ [% END %] >+ [% IF ( cn_loo.barcode ) %] ([% cn_loo.barcode | html %])[% END %] >+ </a> >+ </td> >+ <td style="background:[% cn_loo.background | html %];">[% cn_loo.branchname | html %]</td> >+ <td style="background:[% cn_loo.background | html %];">[% AuthorisedValues.GetByCode( 'CCODE', cn_loo.ccode ) | html %]</td> >+ </tr> >+ [% END %] >+ </tbody> >+ </table> >+</div> <!-- /.page-section --> > > [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31928
:
143582
|
143594
| 143606