Bugzilla – Attachment 143644 Details for
Bug 32145
Cancel hold modal confirm/submit button has a white background and text can't be read
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32145: Fix style of buttons with class .btn-danger
Bug-32145-Fix-style-of-buttons-with-class-btn-dang.patch (text/plain), 2.17 KB, created by
Owen Leonard
on 2022-11-10 12:31:57 UTC
(
hide
)
Description:
Bug 32145: Fix style of buttons with class .btn-danger
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-11-10 12:31:57 UTC
Size:
2.17 KB
patch
obsolete
>From d9b59e85a50c60d0c7781bf0e7d6b2221b0499bf Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 10 Nov 2022 11:49:33 +0000 >Subject: [PATCH] Bug 32145: Fix style of buttons with class .btn-danger > >This patch adds style to the staff client's global SCSS which adds >correct styling to buttons classed with .btn-danger. > >This isn't the correct way to fix this, but it's the fast way. >Rebuilding Bootstrap with custom colors is the correct way, but >Bootstrap 3.x doesn't use SCSS. I consider this is a FIXME for an >upgrade of Bootstrap in the staff interface. > >To test, apply the patch and rebuild the staff interface CSS. Test >instances where the .btn-danger class is used. Two examples: > >Holds: > >- Locate a bibliographic records with holds and view the holds. >- Click the "trash" icon to delete one of the holds. >- In the confirmation modal, check that the "Confirm cancellation" > button looks correct in its default, hover, and active ("clicked") > state. > >Cataloging: > >- Open a new blank record in the basic MARC editor. >- Click "Save" without filling any mandatory fields. >- You should see a warning about the empty fields. >- Scroll down until the warning is offscreen. An "Errors" button should > appear in the toolbar. >--- > .../prog/css/src/staff-global.scss | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index f41f3d729b..7e63d6de3a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -3070,6 +3070,23 @@ button, > border-left: 1px solid darken( saturate( $btn-primary, 15 ), 15 ); > } > } >+ >+ &.btn-danger { >+ background-color: #CC3333; >+ border-color: #9B2323; >+ color: #fff; >+ } >+ >+ &.btn-danger:hover { >+ color: #fff; >+ background-color: #c82333; >+ border-color: #a81c29; >+ } >+ >+ &.btn-danger:not( :disabled ):not( .disabled ).active, >+ &.btn-danger:not( :disabled ):not( .disabled ):active { >+ box-shadow: inset 0 0 0 1px #a81c29; >+ } > } > > #merge-patrons { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32145
:
143497
|
143644
|
143673