From 6e450f6288d4ec08bd5bcae64ee5163554b74e79 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 11 Dec 2012 14:07:48 -0500 Subject: [PATCH] Bug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersToExpunge Signed-off-by: Jonathan Druart --- C4/Members.pm | 8 ++++---- t/db_dependent/lib/KohaTest/Members.pm | 2 +- tools/cleanborrowers.pl | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index b89d721..6388a0f 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -89,7 +89,7 @@ BEGIN { GetBorrowerCategorycode &GetBorrowercategoryList - &GetBorrowersWhoHaveNotBorrowedSince + &GetBorrowersToExpunge &GetBorrowersWhoHaveNeverBorrowed &GetBorrowersWithIssuesHistoryOlderThan @@ -1938,9 +1938,9 @@ WHERE roadtypeid=?|; return ($roadtype); } -=head2 GetBorrowersWhoHaveNotBorrowedSince +=head2 GetBorrowersToExpunge - $borrowers = &GetBorrowersWhoHaveNotBorrowedSince( + $borrowers = &GetBorrowersToExpunge( not_borrowered_since => $not_borrowered_since, expired_before => $expired_before, category_code => $category_code, @@ -1951,7 +1951,7 @@ WHERE roadtypeid=?|; =cut -sub GetBorrowersWhoHaveNotBorrowedSince { +sub GetBorrowersToExpunge { my $params = shift; my $filterdate = $params->{'not_borrowered_since'}; diff --git a/t/db_dependent/lib/KohaTest/Members.pm b/t/db_dependent/lib/KohaTest/Members.pm index dfde7da..35e6e30 100644 --- a/t/db_dependent/lib/KohaTest/Members.pm +++ b/t/db_dependent/lib/KohaTest/Members.pm @@ -48,7 +48,7 @@ sub methods : Test( 1 ) { GetPatronImage PutPatronImage RmPatronImage - GetBorrowersWhoHaveNotBorrowedSince + GetBorrowersToExpunge GetBorrowersWhoHaveNeverBorrowed GetBorrowersWithIssuesHistoryOlderThan GetBorrowersNamesAndLatestIssue diff --git a/tools/cleanborrowers.pl b/tools/cleanborrowers.pl index 6a30326..e350b9d 100755 --- a/tools/cleanborrowers.pl +++ b/tools/cleanborrowers.pl @@ -78,7 +78,7 @@ if ( $params->{'step2'} ) { my $membersToDelete; if ( $checkboxes{borrower} ) { $membersToDelete = - GetBorrowersWhoHaveNotBorrowedSince( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); + GetBorrowersToExpunge( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); $totalDel = scalar @$membersToDelete; } @@ -120,7 +120,7 @@ if ( $params->{'step3'} ) { # delete members if ($do_delete) { my $membersToDelete = - GetBorrowersWhoHaveNotBorrowedSince( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); + GetBorrowersToExpunge( { not_borrowered_since => $filterdate1, expired_before => $borrower_dateexpiry, category_code => $borrower_categorycode } ); $totalDel = scalar(@$membersToDelete); $radio = $params->{'radio'}; if ( $radio eq 'trash' ) { -- 1.7.10.4