Bugzilla – Attachment 144116 Details for
Bug 17350
Add option to delete data stored in saved_reports with cleanup_database
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17350: Purge old saved reports via cleanup_database
Bug-17350-Purge-old-saved-reports-via-cleanupdatab.patch (text/plain), 2.77 KB, created by
Andrew Fuerste-Henry
on 2022-11-21 20:02:30 UTC
(
hide
)
Description:
Bug 17350: Purge old saved reports via cleanup_database
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2022-11-21 20:02:30 UTC
Size:
2.77 KB
patch
obsolete
>From 6792a22dd3d0eda9d013b7cdcfb52c302ba8a963 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >Date: Mon, 21 Nov 2022 20:00:57 +0000 >Subject: [PATCH] Bug 17350: Purge old saved reports via cleanup_database > >To test: >apply patch >1 - have or create a report >2 - run your report via the command line with --store-results. Do this twice. >3 - update the saved_reports table to set date_run for one of your two saved results set to a datetime more than 5 days ago >4 - perl misc/cronjobs/cleanup_database.pl --reports 5 --verbose --confirm >5 - Koha tells you its deleting saved reports data from more than 5 days ago >6 - confirm in the database and the staff interface that it's done so >--- > misc/cronjobs/cleanup_database.pl | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > >diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl >index 96783c159f..2c2940aa70 100755 >--- a/misc/cronjobs/cleanup_database.pl >+++ b/misc/cronjobs/cleanup_database.pl >@@ -113,6 +113,7 @@ Usage: $0 [-h|--help] [--confirm] [--sessions] [--sessdays DAYS] [-v|--verbose] > --bg-days DAYS Purge all finished background jobs this many days old. Defaults to 1 if no DAYS provided. > --bg-type TYPES What type of background job to purge. Defaults to "update_elastic_index" if omitted > Specifying "all" will purge all types. Repeatable. >+ --reports DAYS Purge reports data saved more than DAYS days ago. > USAGE > exit $_[0]; > } >@@ -156,6 +157,7 @@ my @log_modules; > my @preserve_logs; > my $background_days; > my @background_types; >+my $reports; > > my $command_line_options = join(" ",@ARGV); > >@@ -200,6 +202,7 @@ GetOptions( > 'return-claims' => \$return_claims, > 'bg-type:s' => \@background_types, > 'bg-days:i' => \$background_days, >+ 'reports:i' => \$reports, > ) || usage(1); > > # Use default values >@@ -252,6 +255,7 @@ unless ( $sessions > || $cards > || $return_claims > || $background_days >+ || $reports > ) { > print "You did not specify any cleanup work for the script to do.\n\n"; > usage(1); >@@ -702,6 +706,14 @@ if ($background_days) { > } > } > >+if ($reports) { >+ if ( $confirm ) { >+ PurgeSavedReports($reports); >+ } if ( $verbose ) { >+ say "Purging reports data saved more than $reports days ago.\n"; >+ } >+} >+ > cronlogaction({ action => 'End', info => "COMPLETED" }); > > exit(0); >@@ -840,3 +852,12 @@ sub DeleteSpecialHolidays { > print "Removed $count unique holidays\n" if $verbose; > } > >+sub PurgeSavedReports { >+ my ( $reports ) = @_; >+ >+ my $sth = $dbh->prepare(q{ >+ DELETE FROM saved_reports >+ WHERE date(date_run) < DATE_SUB(CURDATE(),INTERVAL ? DAY ); >+ }); >+ $sth->execute( $reports ); >+} >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17350
:
144116
|
145721
|
145722
|
147414
|
147415