Bugzilla – Attachment 144210 Details for
Bug 32257
Label for patron attributes misaligned on patron batch mod
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32257 : Label for Patron Attributes Misaligned
Bug-32257--Label-for-Patron-Attributes-Misaligned.patch (text/plain), 3.29 KB, created by
Matt Blenkinsop
on 2022-11-23 17:19:20 UTC
(
hide
)
Description:
Bug 32257 : Label for Patron Attributes Misaligned
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2022-11-23 17:19:20 UTC
Size:
3.29 KB
patch
obsolete
>From 27e3e487c5d1cef0b604b5537b98c7c768918263 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Wed, 23 Nov 2022 17:12:59 +0000 >Subject: [PATCH] Bug 32257 : Label for Patron Attributes Misaligned > >Label has now been realigned to match the format of the fields above. > >Test Plan: >1) Navigate to Tools > Batch patron modification >2) Add either card or borrower numbers to bring up the edit patrons fields >3) "Patron attributes:" is on the far right and above the select box >4) Apply patch and navigate to same area >5) Observe that the Patron attributes option is aligned to match the fields above >--- > .../prog/en/modules/tools/modborrowers.tt | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index fc666cead9..410e8bc537 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -366,14 +366,16 @@ > [% END %] > [% IF ( patron_attributes_codes ) %] > <li class="attributes"> >- <label style="width:auto;">Patron attribute: >- <select name="patron_attributes"> >- <option value=""></option> >- [% FOREACH pac IN patron_attributes_codes %] >- <option value="[% pac.attribute_code | html %]" data-type="[% pac.type | html %]" data-category="[% pac.category_lib | html %]">[% pac.attribute_lib | html %]</option> >- [% END %] >- </select> >+ <label style="width:auto;"> >+ <span>Patron Attribute:</span> > </label> >+ <select name="patron_attributes"> >+ <option value=""></option> >+ [% FOREACH pac IN patron_attributes_codes %] >+ <option value="[% pac.attribute_code | html %]" data-type="[% pac.type | html %]" data-category="[% pac.category_lib | html %]">[% pac.attribute_lib | html %]</option> >+ [% END %] >+ </select> >+ > <input type="checkbox" title="check to delete this field" name="disable_input" value="attr0_value" /> > <span class="patron_attributes_value"><input type"hidden" name="patron_attributes_value" /></span> > <a href="#" class="add_attributes" title="Add an attribute"><i class="fa fa-fw fa-plus"></i> New</a> >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32257
:
144210
|
144305
|
144443
|
144452
|
144453
|
144489
|
144490