Bugzilla – Attachment 144343 Details for
Bug 32377
GetBudgetHierarchy slows down acqui/histsearch.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32377: Set param skiptotals on call of GetBudgetHierarchy in acqui/histsearch.pl
0001-Bug-32377-Set-param-skiptotals-on-call-of.patch (text/plain), 1.32 KB, created by
Emmi Takkinen
on 2022-11-30 10:34:37 UTC
(
hide
)
Description:
Bug 32377: Set param skiptotals on call of GetBudgetHierarchy in acqui/histsearch.pl
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2022-11-30 10:34:37 UTC
Size:
1.32 KB
patch
obsolete
>From 8a465fe7334f02095413eab625d95cbdf7b90fc7 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Wed, 30 Nov 2022 12:33:19 +0200 >Subject: [PATCH] Bug 32377: Set param skiptotals on call of GetBudgetHierarchy > in acqui/histsearch.pl > >Calling GetBudgetHierarchy from acqui/histsearch.pl >is slow if param skiptotals is not used. > >To test: >1. Open browsers Console -> Network (F12). >2. Navigate to Order search page and perform search. >=> Take a note how long it takes to load the Search results page. >3. Apply this patch. >4. Repeat step 2. >=> Page should now load faster. > >Sponsored-by: Koha-Suomi Oy >--- > acqui/histsearch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/histsearch.pl b/acqui/histsearch.pl >index e44c7db329..097fa3b217 100755 >--- a/acqui/histsearch.pl >+++ b/acqui/histsearch.pl >@@ -124,7 +124,7 @@ if ($do_search) { > my $budgetperiods = C4::Budgets::GetBudgetPeriods; > my $bp_loop = $budgetperiods; > for my $bp ( @{$budgetperiods} ) { >- my $hierarchy = C4::Budgets::GetBudgetHierarchy( $$bp{budget_period_id} ); >+ my $hierarchy = C4::Budgets::GetBudgetHierarchy( $$bp{budget_period_id}, undef, undef, 1 ); > for my $budget ( @{$hierarchy} ) { > $$budget{budget_display_name} = sprintf("%s", ">" x $$budget{depth} . $$budget{budget_name}); > } >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32377
:
144343
|
144891
|
145837