From da192133aee11ce11988f9a7210fc869325b016d Mon Sep 17 00:00:00 2001 From: David Nind Date: Mon, 28 Nov 2022 12:28:34 +0000 Subject: [PATCH] Bug 31984: TaxRate preference - add note about vendor updates If a value for the TaxRates system preference is changed or removed, vendors retain the original value recorded in their tax rate field. The vendor tax rate is used to calculate prices for orders added to a basket. Where the tax rate doesn't match with the system preference, a warning message is displayed on the order form "Tax rate not defined in system preference TaxRates!". This patch adds a note to the system preference description about updating vendor tax rate information where required. Test plan: 1. Check the values recorded for the TaxRates system preference. 2. For a vendor (Acquisitions > search for a vendor > Edit vendor), check the value recorded in the tax rate field. 3. Note that the tax rate field is populated from a dropdown list using values from the TaxRates system preference. 4. Change the TaxRates system preferemce to remove a tax rate. For example, change 0|0.12|0.1965 to 0|0.12. 5. Refresh the vendor page. 6. Note that the vendor tax rate remains as the original value until you edit the vendor. 7. Apply the patch. 8. Review the description for the TaxRates system preference and make sure the new note about updating vendor tax rates where required makes sense. 9. Sign off! Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi --- .../prog/en/modules/admin/preferences/acquisitions.pref | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref index be64e61fd26..3f0560aac56 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref @@ -38,7 +38,8 @@ Acquisitions: - Tax rates are - pref: TaxRates - . Enter in numeric form, 0.12 for 12%. The first item in the list will be selected by default. For more than one value, separate with | (pipe). - - "Please note: The database will only accept values up to 4 decimals precision, further values will be rounded." + - "
NOTE: The database will only accept values up to 4 decimals precision, further values will be rounded." + - "
NOTE: Vendor tax rate information may need updating if tax rate values are removed." - - pref: AcqWarnOnDuplicateInvoice choices: -- 2.34.1