Bugzilla – Attachment 146807 Details for
Bug 32873
Fix cataloguing/value_builder/unimarc_field_686a.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32873: Fix cataloguing/value_builder/unimarc_field_686a.pl
Bug-32873-Fix-cataloguingvaluebuilderunimarcfield6.patch (text/plain), 1.54 KB, created by
Julian Maurice
on 2023-02-17 10:18:26 UTC
(
hide
)
Description:
Bug 32873: Fix cataloguing/value_builder/unimarc_field_686a.pl
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2023-02-17 10:18:26 UTC
Size:
1.54 KB
patch
obsolete
>From 9163523add092d4ae0b85ecbf183802dbfaec668 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 Feb 2023 11:58:55 +0100 >Subject: [PATCH] Bug 32873: Fix > cataloguing/value_builder/unimarc_field_686a.pl > >Use event parameter > >This is part of the refactoring happening in bug 30975 > >Test plan: >1. Verify that the plugin continues to work as before >--- > cataloguing/value_builder/unimarc_field_686a.pl | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_686a.pl b/cataloguing/value_builder/unimarc_field_686a.pl >index d766b038c6..7841f75f8a 100755 >--- a/cataloguing/value_builder/unimarc_field_686a.pl >+++ b/cataloguing/value_builder/unimarc_field_686a.pl >@@ -31,9 +31,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res = " > <script> >-function Clic$function_name(subfield_managed) { >- defaultvalue=document.getElementById(\"$field_number\").value; >- newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_686a.pl&result=\"+defaultvalue+\"&index=$field_number\",\"value_builder\",'width=700,height=600,toolbar=false,scrollbars=yes'); >+function Clic$function_name(event) { >+ event.preventDefault(); >+ defaultvalue=document.getElementById(event.data.id).value; >+ newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_686a.pl&result=\"+defaultvalue+\"&index=\" + event.data.id, \"value_builder\",'width=700,height=600,toolbar=false,scrollbars=yes'); > > } > </script> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32873
:
146139
|
146807
|
150110