Bugzilla – Attachment 147178 Details for
Bug 33044
BackgroundJob enqueue does not return the job id if rabbit is unreachable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33044: Return job id if there is no connection to rabbit
Bug-33044-Return-job-id-if-there-is-no-connection-.patch (text/plain), 1.19 KB, created by
Nick Clemens (kidclamp)
on 2023-02-22 18:15:14 UTC
(
hide
)
Description:
Bug 33044: Return job id if there is no connection to rabbit
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-02-22 18:15:14 UTC
Size:
1.19 KB
patch
obsolete
>From 2a625be3179d4853285c503d075c0449102da63a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 22 Feb 2023 18:13:35 +0000 >Subject: [PATCH] Bug 33044: Return job id if there is no connection to rabbit > >This patch simply ensures we returnt he job id even if we don't send the >job to rabbit > >To test: >1 - In KTD: sudo service rabbitmq-server stop >2 - sudo koha-worker --stop kohadev; sudo koha-worker --queue long_tasks --stop kohadev >3 - In staff client enqueue a batch item modification - note the link to view the enqueued job has no id in the url and takes you to the main background jobs viewer >4 - Apply patch >5 - Restart all >6 - Enqueue a new batch item modification >7 - Confirm the link works and has the correct id >--- > Koha/BackgroundJob.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm >index 0ba7ba46ed..f803c36b05 100644 >--- a/Koha/BackgroundJob.pm >+++ b/Koha/BackgroundJob.pm >@@ -128,7 +128,7 @@ sub enqueue { > } catch { > warn "Cannot connect to broker " . $_; > }; >- return unless $conn; >+ return $self->id unless $conn; > > $json_args = $json->encode($job_args); > try { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33044
:
147178
|
147670
|
147682