Bugzilla – Attachment 147394 Details for
Bug 32991
Improve our Dialog component and remove routes for deletion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32991: Add delete dialog to local packages list
Bug-32991-Add-delete-dialog-to-local-packages-list.patch (text/plain), 3.80 KB, created by
Pedro Amorim
on 2023-02-24 18:31:49 UTC
(
hide
)
Description:
Bug 32991: Add delete dialog to local packages list
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-02-24 18:31:49 UTC
Size:
3.80 KB
patch
obsolete
>From 5422c67444274c3734e96df75eeb8ef9a4a4e979 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 24 Feb 2023 18:30:54 +0000 >Subject: [PATCH] Bug 32991: Add delete dialog to local packages list > >--- > .../ERM/EHoldingsLocalPackagesList.vue | 39 ++++++++++++++++--- > 1 file changed, 34 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >index 348edf92df..ad9f8cad23 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >@@ -32,6 +32,8 @@ export default { > const AVStore = inject("AVStore") > const { get_lib_from_av, map_av_dt_filter } = AVStore > >+ const { setConfirmationDialog, setMessage } = inject("mainStore") >+ > const table_id = "package_list" > useDataTable(table_id) > >@@ -40,6 +42,8 @@ export default { > get_lib_from_av, > map_av_dt_filter, > table_id, >+ setConfirmationDialog, >+ setMessage, > } > }, > data: function () { >@@ -78,10 +82,31 @@ export default { > "/cgi-bin/koha/erm/eholdings/local/packages/edit/" + package_id > ) > }, >- delete_package: function (package_id) { >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/packages/delete/" + >- package_id >+ delete_package: function (package_id, package_name) { >+ this.setConfirmationDialog( >+ { >+ title: this.$__( >+ "Are you sure you want to remove this package?" >+ ), >+ message: package_name, >+ accept_label: this.$__("Yes, delete"), >+ cancel_label: this.$__("No, do not delete"), >+ }, >+ () => { >+ const client = APIClient.erm >+ client.localPackages.delete(package_id).then( >+ success => { >+ this.setMessage(this.$__("Local package deleted")) >+ $("#" + this.table_id) >+ .DataTable() >+ .ajax.url( >+ "/api/v1/erm/eholdings/local/packages" >+ ) >+ .draw() >+ }, >+ error => {} >+ ) >+ } > ) > }, > build_datatable: function () { >@@ -205,6 +230,7 @@ export default { > function (index, e) { > let tr = $(this).parent().parent() > let package_id = api.row(tr).data().package_id >+ let package_name = api.row(tr).data().name > let editButton = createVNode( > "a", > { >@@ -229,7 +255,10 @@ export default { > class: "btn btn-default btn-xs", > role: "button", > onClick: () => { >- delete_package(package_id) >+ delete_package( >+ package_id, >+ package_name >+ ) > }, > }, > [ >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32991
:
146828
|
146829
|
147051
|
147052
|
147053
|
147054
|
147082
|
147083
|
147281
|
147282
|
147291
|
147305
|
147350
|
147383
|
147384
|
147385
|
147387
|
147388
|
147389
|
147390
|
147391
|
147392
|
147393
|
147394
|
147429
|
147439
|
147445
|
147447
|
147448
|
147449
|
147450
|
147451
|
147452
|
147453
|
147454
|
147455
|
147456
|
147461
|
147483
|
147485
|
147486
|
147487
|
147542
|
147543
|
147544
|
147545
|
147546
|
147547
|
147548
|
147549
|
147550
|
147551
|
147552
|
147553
|
147554
|
147569
|
147573
|
147584
|
147588
|
147589
|
147590
|
147591
|
147592
|
147593
|
147594
|
147595
|
147596
|
147597
|
147598
|
147599
|
147600
|
147601
|
147602
|
147603
|
147604
|
147937
|
147938
|
147939
|
147940
|
147941
|
147942
|
147943
|
147944
|
147945
|
147946
|
147947
|
147948
|
147949
|
147950
|
147951