From 2965bd79cc5e2a9f9b3c42e1cef6ceaeb66afc1a Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Wed, 1 Mar 2023 15:13:48 +0000 Subject: [PATCH] Bug 30069: (QA follow-up) Rebase and add filter This patch now checks the status of messages and ignores any message with a status of 'new'. It is also rebased to account for changes made to cleanup_database.pl in bug 17350. Test plan: 1) Ensure you have some EDI orders or even just some dummy messages in the edifact_messages table with a mixture of statuses including 'new' 2) Run perl misc/cronjobs/cleanup_database.pl --edifact-messages 100 --verbose (Change the number of days according to the data in your table) 3) The response should show a number of messages that would have been deleted 4) Run perl misc/cronjobs/cleanup_database.pl --edifact-messages 100 --verbose --confirm 5) The response should now show the same number of messages have been deleted 6) Check your edifact_messages table to confirm that the data has been deleted 7) Confirm that no messages marked 'new' have been deleted --- misc/cronjobs/cleanup_database.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl index 1b74c03f484..0a176aeb437 100755 --- a/misc/cronjobs/cleanup_database.pl +++ b/misc/cronjobs/cleanup_database.pl @@ -901,6 +901,7 @@ sub PurgeEdifactMessages { SELECT id FROM edifact_messages WHERE transfer_date < date_sub(curdate(), INTERVAL ? DAY) + AND status != 'new'; } ); $sth->execute($days) or die $dbh->errstr; -- 2.30.2