Bugzilla – Attachment 148062 Details for
Bug 33161
Implement +strings for GET /items and GET /items/:item_id
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33161: (follow-up) Remove stray variables and fix POD
Bug-33161-follow-up-Remove-stray-variables-and-fix.patch (text/plain), 1.75 KB, created by
Martin Renvoize
on 2023-03-10 11:54:00 UTC
(
hide
)
Description:
Bug 33161: (follow-up) Remove stray variables and fix POD
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2023-03-10 11:54:00 UTC
Size:
1.75 KB
patch
obsolete
>From 48a2f978e75710d84c304d2ee3aa398f55038dac Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 9 Mar 2023 11:36:27 -0300 >Subject: [PATCH] Bug 33161: (follow-up) Remove stray variables and fix POD > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Item.pm | 3 --- > Koha/Object.pm | 5 ++--- > 2 files changed, 2 insertions(+), 6 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 2f77660568..b9c591b973 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -2081,9 +2081,6 @@ sub strings_map { > > my ( $itemtagfield, $itemtagsubfield ) = C4::Biblio::GetMarcFromKohaField("items.itemnumber"); > >- my $public_read_list = $params->{public} ? $self->public_read_list : []; >- my $to_api_mapping = $self->to_api_mapping; >- > # Hardcoded known 'authorised_value' values mapped to API codes > my $code_to_type = { > branches => 'library', >diff --git a/Koha/Object.pm b/Koha/Object.pm >index d01cf1e028..e463f94920 100644 >--- a/Koha/Object.pm >+++ b/Koha/Object.pm >@@ -678,15 +678,14 @@ sub to_api_mapping { > > =head3 strings_map > >- my $params = { is_public => 1 }; > my $string_map = $object->strings_map($params); > > Generic method that returns the string map for coded attributes. > > Return should be a hashref keyed on database field name with the values >-being hashrefs containing 'str', 'type' and optionally 'category'. >+being hashrefs containing 'str', 'type' and optionally 'category'. > >-This is then use in to_api to render the _strings embed when requested. >+This is then used in to_api to render the _strings embed when requested. > > Note: this only returns an empty I<hashref>. Each class should have its > own mapping returned. >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33161
:
147888
|
147973
|
147977
|
147995
|
147998
|
147999
|
148010
|
148011
|
148012
|
148013
|
148014
|
148039
|
148040
|
148041
|
148042
|
148043
|
148059
|
148060
|
148061
| 148062 |
148063
|
148068
|
148075