From c2af83ac7b151031854fe93e9e040128be95d7f7 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Fri, 11 Nov 2022 09:54:05 +0000 Subject: [PATCH 5/7] Bug 16223: (QA follow-up) Move trigger to apply This patch moves the del_restrictions_after_payment from before the actual credit application call inside Koha::Account::pay to after the application of credits to debits in Koha::Account::Line::apply. --- Koha/Account.pm | 3 --- Koha/Account/Line.pm | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/Account.pm b/Koha/Account.pm index 43d8e65f00..e37e646596 100644 --- a/Koha/Account.pm +++ b/Koha/Account.pm @@ -36,7 +36,6 @@ use Koha::Account::DebitTypes; use Koha::Exceptions; use Koha::Exceptions::Account; use Koha::Plugins; -use Koha::Patron::Debarments; =head1 NAME @@ -103,8 +102,6 @@ sub pay { } ); - Koha::Patron::Debarments::del_restrictions_after_payment({ borrowernumber => $self->{patron_id} }); - # NOTE: Pay historically always applied as much credit as it could to all # existing outstanding debits, whether passed specific debits or otherwise. if ( $payment->amountoutstanding ) { diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm index 6ab6120a1a..0d974b390c 100644 --- a/Koha/Account/Line.pm +++ b/Koha/Account/Line.pm @@ -29,6 +29,7 @@ use Koha::Database; use Koha::DateUtils qw( dt_from_string ); use Koha::Exceptions::Account; use Koha::Items; +use Koha::Patron::Debarments; use base qw(Koha::Object Koha::Object::Mixin::AdditionalFields); @@ -701,6 +702,8 @@ sub apply { } }); + Koha::Patron::Debarments::del_restrictions_after_payment({ borrowernumber => $self->borrowernumber }); + return $self; } -- 2.34.1