Bugzilla – Attachment 149673 Details for
Bug 33490
Agreements - Filter by expired results in error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33490: Prevent 400 on agreements?by_expired=true
Bug-33490-Prevent-400-on-agreementsbyexpiredtrue.patch (text/plain), 1.90 KB, created by
Jonathan Druart
on 2023-04-14 12:32:36 UTC
(
hide
)
Description:
Bug 33490: Prevent 400 on agreements?by_expired=true
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-04-14 12:32:36 UTC
Size:
1.90 KB
patch
obsolete
>From 24f2d658f880ddc48d6fb71482bfdf85ad4c4cc6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 12 Apr 2023 12:20:43 +0200 >Subject: [PATCH] Bug 33490: Prevent 400 on agreements?by_expired=true > >We need to update the filter THEN update the current route > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/js/vue/components/ERM/AgreementsList.vue | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index c613a84836b..4712cc5f3e8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -208,6 +208,12 @@ export default { > }, > table_url: function () { > let url = "/api/v1/erm/agreements" >+ if (this.filters.by_expired) { >+ if (!this.filters.max_expiration_date) >+ this.filters.max_expiration_date = new Date() >+ .toISOString() >+ .substring(0, 10) >+ } > if (this.filters.by_expired) > url += > "?max_expiration_date=" + this.filters.max_expiration_date >@@ -221,12 +227,6 @@ export default { > ) > this.$router.push(new_route) > } >- if (this.filters.by_expired) { >- if (!this.filters.max_expiration_date) >- this.filters.max_expiration_date = new Date() >- .toISOString() >- .substring(0, 10) >- } > this.$refs.table.redraw(this.table_url()) > }, > getTableColumns: function () { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33490
:
149519
|
149521
|
149522
|
149523
|
149603
|
149604
|
149615
|
149643
|
149652
|
149661
|
149672
|
149673
|
149674
|
149675
|
149676
|
150038
|
150039
|
150040
|
150048
|
150194
|
150195
|
150196
|
150197
|
150198
|
150199
|
150200
|
150201